This repository was archived by the owner on Apr 20, 2026. It is now read-only.
fix(report): handle BrokenPipe in BasicStdoutReporter#367
Merged
Conversation
Replace println!/eprintln! in BasicStdoutReporter with a write_line
helper that treats BrokenPipe as non-fatal. This prevents panics when
piping compiler output through consumers that may close the pipe early
(e.g. tee, head). Non-BrokenPipe errors still panic, preserving the
prior behavior.
Repro (with uutils-coreutils tee ≤ 0.8):
forge build | tee out.log
Before: exit 134 (SIGABRT/panic)
After: exit 0
Co-Authored-By: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
decofe
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
DaniPopes
approved these changes
Apr 9, 2026
Co-Authored-By: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
zerosnacks
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Piping compiler output to
teecrashes with aBrokenPipepanic. Some widely-deployedteeimplementations (uutils-coreutils ≤ 0.8, default on NixOS and common via Homebrew) close the read end of the pipe during write pauses (e.g. during Solc compilation), causingprintln!()inBasicStdoutReporterto abort.Replace
println!/eprintln!with awrite_linehelper that treatsBrokenPipeas non-fatal. Non-BrokenPipeerrors still panic, preserving the prior behavior.Repro
Before: exit 134 (SIGABRT/panic)
After: exit 0
Changes
println!/eprintln!inBasicStdoutReporterwithwrite_line()helperwrite_line()silently discardsBrokenPipe, panics on other I/O errorsContext
This is the upstream fix for foundry-rs/foundry#14215, which works around this issue by duplicating
BasicStdoutReporterasSafeStdoutReporterin foundry. Fixing it here eliminates the need for a downstream copy.Prompted by: zerosnacks