Skip to content

Conversation

@doanac
Copy link
Member

@doanac doanac commented Dec 15, 2025

No description provided.

@doanac
Copy link
Member Author

doanac commented Dec 15, 2025

I was hesitant to pull in the nanoid stuff, but it does make the tests a lot more readable (better than b32 in my opinion). You can see before(regular UUID) and after here:

$ ./bin/fioctl-linux-amd64 devices tests qc-t14-qemu
NAME       STATUS  ID                                    CREATED AT
----       ------  --                                    ----------
dmesg-man  PASSED  3528fb7a-f9fb-470e-8e24-5f108e4b92b5  2025-07-24 16:19:12 +0000 UTC
diag-man   FAILED  e83ea855-5ef0-408c-902a-f42577237576  2025-07-24 16:27:44 +0000 UTC
diag-man   PASSED  7ec2e4d6-a391-4208-a226-f03f6c53a318  2025-07-24 16:32:00 +0000 UTC
diag       PASSED  diag_zTK-B2kMXtIp1vl                  2025-08-22 16:12:48 +0000 UTC
diag       PASSED  diag_cTLD_J_Nu6mSRpW                  2025-08-26 16:38:24 +0000 UTC
diag       PASSED  diag_2gKXjezZzcL_I9D                  2025-08-27 15:40:48 +0000 UTC
diag       PASSED  diag_VCoCdjGwzxLErhh                  2025-12-12 23:02:24 +0000 UTC
reboot     FAILED  reboot_fUeLdVza6kh2PkZ                2025-12-12 23:04:32 +0000 UTC
diag       PASSED  diag_8u_42JiMRZ9VAhR                  2025-12-12 23:13:04 +0000 UTC
reboot     FAILED  reboot_7Dol0brjAaiIMjS                2025-12-12 23:13:04 +0000 UTC
reboot     FAILED  reboot_hr6BlnBX7b_jKLT                2025-12-12 23:17:20 +0000 UTC
reboot     PASSED  reboot_fZA31Esg2tGRxRY                2025-12-12 23:30:08 +0000 UTC

@doanac doanac requested a review from vkhoroz December 15, 2025 14:48
Signed-off-by: Andy Doan <andy@foundries.io>
Copy link
Member

@vkhoroz vkhoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants