Skip to content

Conversation

@mike-sul
Copy link
Collaborator

Defining a compose app proxy as a function in the configuration provides the compose app API clients to define runtime logic for obtaining URL and/or CA cert of the proxy server.

In particular, a client does not need to know which of the API functions makes a call to a container registry, hence it does not need to set the proxy before invoking each such the API call. Instead composeapp invokes a client provided function/callback to provide the proxy URL and CA whenever a random API function of composeapp needs it.

@mike-sul mike-sul requested review from detsch and doanac December 16, 2025 19:17
@doanac
Copy link
Member

doanac commented Dec 16, 2025

The idea works for me. Just remember to pull out the fmt.Printf debugging before you finalize.

@mike-sul mike-sul force-pushed the improve-proxy-config branch from aa3d786 to f9eb6ed Compare December 17, 2025 10:22
@mike-sul mike-sul marked this pull request as ready for review December 17, 2025 10:22
@mike-sul
Copy link
Collaborator Author

@doanac I verified it for the aklite v96 and the latest version of the satellite server just to make sure no regression, and it works fine.
Also, tested it for fioup foundriesio/fioup#183.

Defining a compose app proxy as a function in the configuration
provides the compose app API clients to define runtime logic for
obtaining URL and/or CA cert of the proxy server.

In particular, a client does not need to know which of the API functions
makes a call to a container registry, hence it does not need to set the
proxy before invoking each such the API call. Instead composeapp invokes
a client provided function/callback to provide the proxy URL and CA
whenever a random API function of composeapp needs it.

Signed-off-by: Mike Sul <mike.sul@foundries.io>
@mike-sul mike-sul force-pushed the improve-proxy-config branch from f9eb6ed to 48ee670 Compare December 17, 2025 14:26
@mike-sul mike-sul merged commit 4f79b3b into main Dec 17, 2025
2 checks passed
@mike-sul mike-sul deleted the improve-proxy-config branch December 17, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants