image_loader: Correctly count image loading responses from dockerd #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerd emits an "image loaded" response for each tag reference listed in an image manifest. This means that if an image has N tag references, dockerd will send the "image loaded" response N times, even though the image blobs are only loaded once. Additionally, when a digest reference is used in the "RepoTags" field of an image load manifest, dockerd sends the "image loaded" response only once, regardless of the number of tag references. This commit updates the image loading logic to account for these behaviors and correctly count the responses. Signed-off-by: Mike Sul <mike.sul@foundries.io>
detsch
reviewed
Nov 25, 2025
detsch
approved these changes
Nov 25, 2025
Make sure the current image index doesn't exceed the image URI slice size before using it. If it exceeds, then print warning message. Signed-off-by: Mike Sul <mike.sul@foundries.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerd emits an "image loaded" response for each tag reference listed in an image manifest. This means that if an image has N tag references, dockerd will send the "image loaded" response N times, even though the image blobs are only loaded once.
Additionally, when a digest reference is used in the "RepoTags" field of an image load manifest, dockerd sends the "image loaded" response only once, regardless of the number of tag references.
This commit updates the image loading logic to account for these behaviors and correctly count the responses.