update: Add option to force update completion #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to do forced update completion. Signed-off-by: Mike Sul <mike.sul@foundries.io>
Don't mark an update as "failed" if the "complete" fails. The "complete" call is allowed only if an update is successfully started or is in "completing" state, hence it doesn't make sense to "fail" it because the update is actually successful. Instead, if an error occurs, keep the update record in "completing" state. A user/caller can call the forced completion if it is needed. Signed-off-by: Mike Sul <mike.sul@foundries.io>
detsch
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to do forced update completion.