Conversation
Grid adjustments related to getglad/inky@25c4441
|
Thanks for the PR! How does adding the extra class solve the problem? Is the redundancy of the classes the solution? We'd love to understand this better! |
|
The real improvement is in Inky (foundation/inky#34) - realizing now that I didn't link directly to that PR. The naming convention may not be the best/clearest, but I didn't want to submit a PR to Inky that could end up being a breaking change to folks' existing templates. So instead I created a second/similar element that would allow for the additional rows and avoid reusing element names. This addition to the the Update/Edit:
So that actually made me realize 1 other thing. I can leave the Inky template change in to get the additional component (table + more than 1 row), but make the style names to be the same (styled as So, I need to do one of two things:
I would lean towards doing # 1, but I know you service both, so maybe you have a preference / a different suggestion? |
See getglad/inky@25c4441
Partially resolves #308
Happy to answer any questions