Skip to content

New image placeholders#2105

Closed
seho-nl wants to merge 4 commits intofoundation:developfrom
seho-nl:new-image-placeholder
Closed

New image placeholders#2105
seho-nl wants to merge 4 commits intofoundation:developfrom
seho-nl:new-image-placeholder

Conversation

@seho-nl
Copy link
Copy Markdown
Contributor

@seho-nl seho-nl commented Feb 25, 2025

The images in the current documentation links to an image placeholder endpoint that does not exists anymore. It looks like the team behind https://placehold.it either quit or moved it to https://placehold.co.

Either way, I updated the documentation files so that the images render properly again.

@joeworkman
Copy link
Copy Markdown
Member

Closing in favor of #2106 which was merged. Thanks for the contribution!

@joeworkman joeworkman closed this Mar 11, 2026
@seho-nl
Copy link
Copy Markdown
Contributor Author

seho-nl commented Mar 11, 2026

I don't really understand why you choose #2106 over this merge.
#2016 fixes only one page where my merge looked at all other pages as well.

@joeworkman joeworkman reopened this Mar 11, 2026
@joeworkman
Copy link
Copy Markdown
Member

Thanks for the feedback guys. I will get this fixed this afternoon.

@joeworkman
Copy link
Copy Markdown
Member

Shipping this as 2.5.1 now. Thanks guys!

@joeworkman joeworkman closed this Mar 12, 2026
@simonschaufi
Copy link
Copy Markdown

@joeworkman I still don't see the new placeholder images on the website. Is it deployed already?

https://get.foundation/emails/docs/grid.html#offsets

@joeworkman
Copy link
Copy Markdown
Member

All working. The site build was not working. Should be good now.

Go check out Inky 2! This basically consolidates Foundation for Email and Inky into one tool. It also has a ton more features now. The CLI version is the most tested and pretty stable (for me at least). I would love your feedback. https://github.com/foundation/inky/tree/feature/2.0-rust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants