[Draft] Add dev stage to dockerfile#283
Open
alex-jw-brooks wants to merge 1 commit intofoundation-model-stack:mainfrom
Open
[Draft] Add dev stage to dockerfile#283alex-jw-brooks wants to merge 1 commit intofoundation-model-stack:mainfrom
alex-jw-brooks wants to merge 1 commit intofoundation-model-stack:mainfrom
Conversation
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
anhuong
reviewed
Aug 6, 2024
Comment on lines
+186
to
+187
| # TODO - probably a good idea to install most stuff in common and copy it out | ||
| # in both this stage and dev. |
Collaborator
There was a problem hiding this comment.
Or similarly, could the dev stage come after the python building stage? But the dev stage adds the additional tools and then release stage removes the unnecessary parts? I guess it may be hard to install the dev tools and selectively remove them...
Comment on lines
-108
to
+101
| ARG ENABLE_AIM=false | ||
| ARG ENABLE_AIM |
Collaborator
There was a problem hiding this comment.
Probably no longer need this build arg in this stage since its used in later stages unless we want to setup the aim_profile in this stage and copy it in other stages. But I think you'd still need the if block so doesn't save too much
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Related issue number
How to verify the PR
Was the PR tested