Loader ckp fixes#119
Merged
daviswer merged 7 commits intofoundation-model-stack:mainfrom Oct 11, 2024
Merged
Conversation
daviswer
force-pushed
the
loader_ckp_fixes
branch
from
6685b0b to
57167f3
Compare
Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
Signed-off-by: Johannes Schmude <Johannes.Schmude@ibm.com> Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
daviswer
force-pushed
the
loader_ckp_fixes
branch
from
57167f3 to
3adfb7d
Compare
Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
Signed-off-by: Davis Wertheimer <davis.wertheimer@ibm.com>
Collaborator
Author
|
@sahilsuneja1 verifying that this update to the |
Collaborator
|
@daviswer Confirming speculator training for |
sahilsuneja1
approved these changes
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
get_latestandget_oldestto use the same sorting function, and allows the dataloader ckp handler to pass in its custom sort manually. Removes the bug where excessive path joins lead to repeated path prefixes in dataloader ckp loading. Fixes GPTBigCode signatures used for speculator training, to match superclass signatures (currently preventing other PRs from landing).Includes and subsumes #110 and #96. Full credit to @weiji14 and @Akash-Nayak respectively