feat(ci): add new ci for commit format checking#186
Conversation
|
Hi @deo002 and @ChayanDass, what do you think about it ? |
824cb86 to
87f3d7b
Compare
|
Yep, sounds perfect! @im-vishesh15th |
|
Hi @im-vishesh15th , Instead of creating specific regex and scripting your way out we can utilise, already provided tools from github actions (helps us reduce maintainability). Here are the links to such: Lint Commits: https://github.com/fossology/fossology/blob/792818e5d6968c6fbe19193f25d2c54e8ea31e90/.github/workflows/static-checks.yml#L120 Also include the DCO Check: And we dont need a pre-commit check for now. Tests in CI for each PR will do just fine. |
50fa71c to
44a45c5
Compare
|
Hey @deo002 and @Kaushl2208 |
|
@im-vishesh15th , Looks good now. Can you rebase the branch? |
44a45c5 to
d277fdc
Compare
|
I have done the rebase |
d277fdc to
dafbf0b
Compare
dafbf0b to
5ea246b
Compare
Kaushl2208
left a comment
There was a problem hiding this comment.
LGTM..
Thanks for your contributions @im-vishesh15th
|
Hi @im-vishesh15th , Can you also add a verified signature to your commit. |
5ea246b to
22c98ff
Compare
22c98ff to
a236155
Compare
Signed-off-by: Vishesh Gupta <vishesh15th@gmail.com>
|
i have verified and signed my commits, please check! |
issue#182
Changes
<type>(<scope>): <subject>Example of a valid commit message
Submitter Checklist