Skip to content

Pass execution_time as UTC#18

Open
polivbr wants to merge 2 commits intofosk06:mainfrom
polivbr:main
Open

Pass execution_time as UTC#18
polivbr wants to merge 2 commits intofosk06:mainfrom
polivbr:main

Conversation

@polivbr
Copy link
Copy Markdown

@polivbr polivbr commented Oct 2, 2025

Pull Request

Description

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🧹 Code refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test improvements
  • 🔧 CI/CD changes

Related Issues

Fixes #17
Closes #17

Changes Made

Pass UTC timezone to datetime.now() call used to generate execution_time.

Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • All existing tests pass
  • Manual testing performed

Test Commands

# Commands used to test the changes
make test
make lint
make vulture

Checklist

Code Quality

  • Code follows the project's style guidelines
  • Self-review of the code completed
  • Code is properly commented (especially complex logic)
  • No dead code or unused imports
  • All functions have appropriate docstrings

Testing

  • Tests have been added for new functionality
  • All tests pass locally
  • Test coverage maintained or improved
  • Manual testing completed

Documentation

  • Documentation updated (if applicable)
  • GitHub Release notes will be updated (for notable changes)
  • ADR created/updated (for architectural decisions)
  • Examples updated (if public API changed)

Dependencies

  • No new dependencies added (or justified in description)
  • pyproject.toml updated (if dependencies changed)
  • uv.lock updated

Breaking Changes

None / Describe breaking changes here

Performance Impact

No impact / Describe performance changes

Screenshots

Additional Notes


For Reviewers

Review Areas

  • Code quality and style
  • Test coverage and quality
  • Documentation completeness
  • Performance implications
  • Breaking change assessment
  • Security considerations

Testing Instructions


Thank you for contributing to dg-sqlmesh! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: execution_time passed to plan needs to be UTC

1 participant