refactor: extract duplicate parameter encoding logic#7
Merged
RoseSecurity merged 1 commit intomainfrom Mar 2, 2026
Merged
Conversation
Extract encodeAliasParams and encodeDomainParams helper functions to reduce code duplication in CreateAlias/UpdateAlias and CreateDomain/UpdateDomain methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and Why
This pull request refactors parameter encoding logic for domain and alias management in the ForwardEmail client, improving code reusability and maintainability. The main changes involve extracting repeated code for encoding parameters into dedicated helper functions, and updating the relevant methods to use these helpers.
Refactoring and Code Reuse:
encodeAliasParamshelper function inforwardemail/aliases.goto centralize and simplify alias parameter encoding, replacing duplicated logic in bothCreateAliasandUpdateAlias. [1] [2] [3]encodeDomainParamshelper function inforwardemail/domains.goto handle domain parameter encoding, removing repeated code fromCreateDomainandUpdateDomain. [1] [2] [3]