refactor: add context support and improve error handling#6
Merged
RoseSecurity merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
- Add context.Context as first parameter to all API methods - Replace ClientOptions struct with functional options pattern - Add WithHTTPClient and WithAPIURL option functions - Introduce APIError type for structured error responses - Add input validation with sentinel errors for common cases - URL-encode path parameters to prevent injection - Use http.NewRequestWithContext for proper cancellation - Make Client fields private for better encapsulation - Accept 2xx status codes instead of only 200/204 - Update tests to use new client constructor and context - Bump github.com/google/go-cmp to v0.7.0 - Add gofumpt, goimports, and golangci-lint to tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what