FIO-10415: Update select's choices classes to be compatible with choices 11#264
Merged
lane-formio merged 1 commit intomasterfrom Aug 25, 2025
Merged
FIO-10415: Update select's choices classes to be compatible with choices 11#264lane-formio merged 1 commit intomasterfrom
lane-formio merged 1 commit intomasterfrom
Conversation
blakekrammes
force-pushed
the
fio-10415
branch
2 times, most recently
from
7471b79 to
41e30d0
Compare
blakekrammes
force-pushed
the
fio-10415
branch
4 times, most recently
from
a00530a to
77aa456
Compare
…ces 11 - The update was made to select in @formio/js, but not here - https://github.com/Choices-js/Choices/blob/main/CHANGELOG.md#chore-7
blakekrammes
force-pushed
the
fio-10415
branch
from
77aa456 to
6eeac53
Compare
blakekrammes
commented
Aug 22, 2025
| steps: | ||
| - name: Download build artifact | ||
| uses: actions/download-artifact@v3 | ||
| uses: actions/download-artifact@v4 |
Contributor
Author
There was a problem hiding this comment.
v3 was deprecated and the publish job wouldn't run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-10415
Description
What changed?
Set choices.js class names as an array instead of a concatenated string.
Why have you chosen this solution?
Clean and simple.
Breaking Changes / Backwards Compatibility
This change will break @formio/js < 5.2.1, which is when choices.js 11 was introduced. I added a peer dependency version for @formio/js to indicate compatibility.
Dependencies
@formio/js >= 5.2.1
How has this PR been tested?
With my two hands.
Checklist: