-
Notifications
You must be signed in to change notification settings - Fork 5
BugFix - Unable to present when a VC is already presented #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hassaan4584
wants to merge
6
commits into
formbricks:main
Choose a base branch
from
hassaan4584:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9400e2b
IOS-6487 Add topMostVC for presenter
8da5a45
Merge pull request #1 from flix-tech/bugfix/IOS-6487_Add_topMostVC_fo…
narjes-abs ceab083
Update bg color
narjes-abs 70ddb6f
Update FormbricksView fix gap
narjes-abs b7a6beb
Issue fixed where the survey would not be presented when there is a v…
hassaan4584 e5753ac
Merge branch 'main' into main
hassaan4584 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
Sources/FormbricksSDK/Extension/UIWindow+topMostViewController.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import UIKit | ||
|
|
||
| extension UIWindow { | ||
| func topMostViewController() -> UIViewController? { | ||
| if let rootViewController: UIViewController = self.rootViewController { | ||
| return UIWindow.topMostViewControllerFrom(rootViewController) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| static func topMostViewControllerFrom(_ viewController: UIViewController) -> UIViewController { | ||
| if let navigationController = viewController as? UINavigationController, | ||
| let visibleController = navigationController.visibleViewController { | ||
| return topMostViewControllerFrom(visibleController) | ||
| } else if let tabBarController = viewController as? UITabBarController, | ||
| let selectedTabController = tabBarController.selectedViewController { | ||
| return topMostViewControllerFrom(selectedTabController) | ||
| } else { | ||
| if let presentedViewController = viewController.presentedViewController { | ||
| return topMostViewControllerFrom(presentedViewController) | ||
| } else { | ||
| return viewController | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Infinite recursion when
visibleViewControllerorselectedViewControlleris nil.If a
UINavigationControllerhas no view controllers in its stack (visibleViewController == nil), or aUITabBarControllerhas no tabs (selectedViewController == nil), the fallback?? navigation/?? tabBarpasses the same container back totopViewController, causing infinite recursion and a stack overflow.🐛 Proposed fix to prevent infinite recursion
private func topViewController(from viewController: UIViewController) -> UIViewController { if let presented = viewController.presentedViewController { return topViewController(from: presented) } - if let navigation = viewController as? UINavigationController { - return topViewController(from: navigation.visibleViewController ?? navigation) + if let navigation = viewController as? UINavigationController, + let visible = navigation.visibleViewController { + return topViewController(from: visible) } - if let tabBar = viewController as? UITabBarController { - return topViewController(from: tabBar.selectedViewController ?? tabBar) + if let tabBar = viewController as? UITabBarController, + let selected = tabBar.selectedViewController { + return topViewController(from: selected) } return viewController }📝 Committable suggestion
🤖 Prompt for AI Agents