Streamline Podcast handler code with a POSO#52
Draft
chickdan wants to merge 7 commits intoforem:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to make the code-base a little more Swifty so I created a
Podcastobject and incorporated some json serialization to make the code a little more streamlined.I don't know how to test this as there doesn't seem to be a repo for the Forem app and Dev-ios is deprecated as a product (if there is a repo I would love to contribute as there appears to be a theming issue with the status bar and bottom toolbar). So if you find anything please let me know, this is experimental in the meantime. If all goes well I can open PRs for other objects, thanks!