Conversation
…notes * Adds `role="radiogroup"` to the root note container in `SamplerVoicePanel` * Implements `role="radio"`, `aria-checked`, and roving `tabIndex` for `LadderButton` options * Adds ArrowUp/ArrowDown navigation explicitly to the root note radiogroup * Ensures screen readers announce the custom Root Note selection correctly Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
ford442
deleted the
palette-sampler-voice-panel-a11y-12264927643058519248
branch
…-12264927643058519248 🎨 Palette: [UX improvement] Add accessible radio group semantics & keyboard nav to Sampler Voice Panel Root Notes
1 participant
💡 What: Refactored the Root Note selection in
SamplerVoicePanelto act as a proper WAI-ARIA Radio Group instead of a list of separate, standalone custom buttons.🎯 Why: Previously, custom
LadderButtonelements rendered simply as generic buttons. Keyboard users had to tab through every single root note option one by one, and screen readers lacked the context that these options form a mutually exclusive list (a radio group).📸 Before/After:
Before:
LadderButtonwas just a button wrapper. No focus states.After: Full visual focus ring on selection, Up/Down arrow key mapping, valid radio group semantic DOM.
♿ Accessibility:
role="radiogroup"witharia-labelledbyreferencing "Root Note Selection".role="radio"andaria-checked={isSelected}toLadderButton.tabIndex={isSelected ? 0 : -1}) so users tab into the group once, then use arrow keys to navigate options (matching native radio inputs).PR created automatically by Jules for task 12264927643058519248 started by @ford442