Skip to content

@W-22954921: [iOS] Stabilize flaky test testMissingLoginHint #4062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnsonEricAtSalesforce merged 3 commits into from
Jun 12, 2026
+11 −13
Merged

@W-22954921: [iOS] Stabilize flaky test testMissingLoginHint #4062

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
154a54d
@W-22954921: [iOS] Stabilize flaky test testMissingLoginHint (trivial…
JohnsonEricAtSalesforce Jun 11, 2026
5838081
@W-22954921: [iOS] Stabilize flaky test testMissingLoginHint (remove …
JohnsonEricAtSalesforce Jun 12, 2026
a5ef33b
@W-22954921: [iOS] Restore useful Given comments and simplify class doc
JohnsonEricAtSalesforce Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions libs/SalesforceSDKCore/SalesforceSDKCoreTests/DomainDiscoveryCoordinatorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
import XCTest
@testable import SalesforceSDKCore

/// Tests for DomainDiscoveryCoordinator. We call `handle(callbackURL:)` directly with a URL
/// instead of building a MockNavigationAction, because subclassing WKNavigationAction and
/// calling super.init() can trigger an abort in WebKit on CI (signal abrt).
@MainActor
/// Tests for DomainDiscoveryCoordinator. These exercise synchronous URL-parsing logic
/// via `handle(callbackURL:)` directly.
final class DomainDiscoveryCoordinatorTests: XCTestCase {

func testCallbackSuccess() async throws {
func testCallbackSuccess() throws {
// Given
let coordinator = DomainDiscoveryCoordinator()
let expectedDomain = "foo.my.salesforce.com"
Expand All @@ -26,7 +24,7 @@ final class DomainDiscoveryCoordinatorTests: XCTestCase {
XCTAssertEqual(results?.loginHint, expectedLoginHint)
}

func testMissingMyDomain() async throws {
func testMissingMyDomain() throws {
// Given
let coordinator = DomainDiscoveryCoordinator()
let expectedLoginHint = "testuser@example.com"
Expand All @@ -41,8 +39,8 @@ final class DomainDiscoveryCoordinatorTests: XCTestCase {
XCTAssertNil(results)
}

func testMissingLoginHint() async throws {
// Given: callback URL with my_domain only (no login_hint). Build via URLComponents so parsing is deterministic on all platforms.
func testMissingLoginHint() throws {
// Given: callback URL with my_domain but no login_hint
let coordinator = DomainDiscoveryCoordinator()
var components = URLComponents()
components.scheme = "sfdc"
Expand All @@ -57,7 +55,7 @@ final class DomainDiscoveryCoordinatorTests: XCTestCase {
XCTAssertNil(results)
}

func testMalformedCallbackURL() async throws {
func testMalformedCallbackURL() throws {
// Given
let coordinator = DomainDiscoveryCoordinator()
let callbackURLString = "sfdc://discocallback?my_domain=&login_hint="
Expand All @@ -71,8 +69,8 @@ final class DomainDiscoveryCoordinatorTests: XCTestCase {
XCTAssertEqual(results?.loginHint, "")
}

func testNonCallbackURL() async throws {
// Given: URL that is not a domain discovery callback. Build via URLComponents so parsing is deterministic on all platforms.
func testNonCallbackURL() throws {
// Given: URL that is not a domain discovery callback
let coordinator = DomainDiscoveryCoordinator()
var components = URLComponents()
components.scheme = "https"
Expand All @@ -86,7 +84,7 @@ final class DomainDiscoveryCoordinatorTests: XCTestCase {
XCTAssertNil(results)
}

func testSpecialCharactersInLoginHint() async throws {
func testSpecialCharactersInLoginHint() throws {
// Given
let coordinator = DomainDiscoveryCoordinator()
let expectedDomain = "foo.my.salesforce.com"
Expand All @@ -105,7 +103,7 @@ final class DomainDiscoveryCoordinatorTests: XCTestCase {
XCTAssertEqual(results?.loginHint, expectedLoginHint)
}

func testExtraQueryParameters() async throws {
func testExtraQueryParameters() throws {
// Given
let coordinator = DomainDiscoveryCoordinator()
let expectedDomain = "foo.my.salesforce.com"
Expand Down
Loading