Skip to content

@W-22954918: [iOS] Stabilize flaky test testBootConfigPickerViewRendered #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnsonEricAtSalesforce merged 4 commits into from
Jun 12, 2026
Merged

@W-22954918: [iOS] Stabilize flaky test testBootConfigPickerViewRendered #4061

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
16f1266
@W-22954918: [iOS] Stabilize flaky test testBootConfigPickerViewRende…
JohnsonEricAtSalesforce Jun 11, 2026
741f4bc
@W-22954918: [iOS] Stabilize flaky test testBootConfigPickerViewRende…
JohnsonEricAtSalesforce Jun 11, 2026
2e8d31b
@W-22954918: [iOS] Strengthen assertion to verify view layout
JohnsonEricAtSalesforce Jun 12, 2026
a2879dd
@W-22954918: [iOS] Restore appearance transition comment
JohnsonEricAtSalesforce Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 13 additions & 19 deletions libs/SalesforceSDKCore/SalesforceSDKCoreTests/LoginOptionsViewControllerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ class LoginOptionsViewControllerTests: XCTestCase {
}

func testBootConfigPickerViewRendered() {
let expectation = XCTestExpectation(description: "View works with existing BootConfig")

// Create a test BootConfig
let testConfig: [String: Any] = [
"remoteAccessConsumerKey": "test_boot_config_key",
Expand All @@ -90,34 +88,30 @@ class LoginOptionsViewControllerTests: XCTestCase {
"shouldAuthenticate": true
]
SalesforceManager.shared.bootConfig = BootConfig(testConfig)

let view = LoginOptionsView {
// No-op callback
}

let hostingController = UIHostingController(rootView: view)

// Create a window and add the view controller
let window = UIWindow(frame: CGRect(x: 0, y: 0, width: 375, height: 667))
window.rootViewController = hostingController
window.makeKeyAndVisible()

// Trigger view lifecycle (use appearance transition APIs to avoid callback misuse warning)
hostingController.beginAppearanceTransition(true, animated: false)
hostingController.endAppearanceTransition()

DispatchQueue.main.asyncAfter(deadline: .now() + 0.2) {
// Verify view rendered with BootConfig
XCTAssertNotNil(hostingController.view)

// Clean up
window.rootViewController = nil
window.isHidden = true

expectation.fulfill()
}

wait(for: [expectation], timeout: 2.0)

// Verify view rendered with non-zero layout (frame.height relies only on UIKit layout,
// avoiding SwiftUI internals like subview count which could vary across OS versions)
hostingController.view.layoutIfNeeded()
XCTAssertGreaterThan(hostingController.view.frame.height, 0)

// Clean up
window.rootViewController = nil
window.isHidden = true
}

func testStaticConfigButtonAction() {
Expand Down
Loading