FOLIO-4308 move erm-comparisons module to app-agreements#7
FOLIO-4308 move erm-comparisons module to app-agreements#7NikitaSedyx wants to merge 3 commits intomasterfrom
Conversation
EthanFreestone
left a comment
There was a problem hiding this comment.
Does this application descriptor not also need a platform minimal dep like the others? Or is that assumed to be transient via agreements?
If the latter, who is generally responsible for making sure there's that base layer compatibility on app descriptors, feels like it could become a bit of a birds nest quite quickly.
|
it's transient, agreements require minimal as a result erm-usage will have both minimal + agreements |
|
Hmmm, ok then I can see how this will work but it does seem like we end up in a situation where the implementor then has to do work to find out whether the app contains the minimal viable descriptors. This doesn't block the PR at all, it just strikes me as something that could do with clarity at some pt |
|
@NikitaSedyx why does this add a dependency to app-agreements? Is there a dependency somewhere between eusage and Agreements ? (I think eusage can function without agreements, but I may have missed something) |
No description provided.