DXCC Stats still including deleted entities - AwardsDialog.cpp

[aa5sh]

I noticed the when looking at code for the email earlier that the DXCC counts were still including Deleted Entities. Mine was showing 323 instead of 320 confirmed. I made an adjustment to correct but not sure if it is the ideal way.

[foldynl]

I'm a little confused now. So should deleted entities be included or not? I fixed it to include deleted entities. This doesn't work?

[aa5sh]

I would think they shouldn’t count in the summary at the top if they are not in the detailed list by country. They were and I put in a pull request i thought to exclude them. The summary at the top were counting them and the details below were not so it was inconsistent. I would think they should match. It is a little confusing now.

…

On Wed, Mar 19, 2025 at 5:09 AM Ladislav ***@***.***> wrote: I'm a little confused now. So should deleted entities be included or not? I fixed it to include deleted entities. This doesn't work? — Reply to this email directly, view it on GitHub <#620 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUEEMXQHGAT7EEYLKIOQ44L2VE64JAVCNFSM6AAAAABZJH4HPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZWGAZDMNBUGE> . You are receiving this because you authored the thread.Message ID: ***@***.***> [image: foldynl]*foldynl* left a comment (foldynl/QLog#620) <#620 (comment)> I'm a little confused now. So should deleted entities be included or not? I fixed it to include deleted entities. This doesn't work? — Reply to this email directly, view it on GitHub <#620 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUEEMXQHGAT7EEYLKIOQ44L2VE64JAVCNFSM6AAAAABZJH4HPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZWGAZDMNBUGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[foldynl]

Please, could you send me an example ? I changed the Awards in 0.42.2 where delete entities ARE included in the details AND are counted at the top - commit da70f4a

[aa5sh]

Sorry I guess I didn’t look in the details I see now I have entries with just a number and no prefix/name. Would you consider having an option at the top to include/exclude deleted countries? I just saw the count and knew it was high. I’ll go in and remove this pull request in a bit or you can either way. Sorry for the confusion.

…

On Mar 19, 2025, at 6:00 AM, Ladislav ***@***.***> wrote: foldynl left a comment (foldynl/QLog#620) Please, could you send me an example ? I changed the Awards in 0.42.2 where delete entities ARE included in the details AND are counted at the top - commit da70f4a — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread. <da70f4a> <#620 (comment)> <https://github.com/notifications/unsubscribe-auth/AUEEMXUC6SDN34AJKUBZC332VFE3HAVCNFSM6AAAAABZJH4HPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZWGIYTCOBVG4> foldynl left a comment (foldynl/QLog#620) <#620 (comment)> Please, could you send me an example ? I changed the Awards in 0.42.2 where delete entities ARE included in the details AND are counted at the top - commit da70f4a <da70f4a> — Reply to this email directly, view it on GitHub <#620 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUEEMXUC6SDN34AJKUBZC332VFE3HAVCNFSM6AAAAABZJH4HPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZWGIYTCOBVG4>. You are receiving this because you authored the thread.

[foldynl]

Would you consider having an option at the top to include/exclude deleted countries? I just saw the count and knew it was high.

That's a good question. I'll have to look into the DXCC rules. But if DXCC accepts removed entities, then we should NOT implement such an option.

[iu0dhv]

Hello it was me to suggest to include deleted entities in the list (also because if you want to add past QSOs it is good to have the possibility to include them with the proper dxcc attribution). And actually the are indeed reported by the ARRL in the list of worked countries and properly labelled as deleted. So thank you very much for adding them in one of the latest release of the log.
At the same I would also like to have a flag that allows to include or exclude them from the count of Worked/Confirmed countries on the top lines of the Award window. So it would be great if this could be added!
73

[foldynl]

I think we already solved it in the previous version.