Fix WSJT-X QSO panel mode updates#1055
Open
VA3THP wants to merge 1 commit into
Open
Conversation
Owner
|
I have no comments on the fix in WsjtxUDPReceiver.cpp. Thanks. Regarding the change in WsjtxWidget.cpp, I have several comments. The main point is that the intention to change the mode only on a disconnected rig was intentional. Unfortunately, your fix can cause the rig mode change to compete with the mode information from WSJT-X. That is quite an undesirable side effect. The second side effect is that your code changes the band filter width every time a status message from WSJT-X is received. This is also unwanted. The rig should be fully controlled by WSJT-X. QLog should not make any decisions in this case. Or did I miss something? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WSJT-X sends QLog both the current decode mode and the TX/logging mode in its
Status message. For the New Contact panel, the TX/logging mode is the one that
matters: it is the mode WSJT-X will use for the QSO, and it affects things like
worked-before checks.
This fixes two small issues in that path:
tx_modewas parsed, butstatus.tx_modewas accidentally filled withmode, so the actual TX mode was lost.connected. With a rig connected, the panel could keep the rig's data mode
instead of the WSJT-X QSO mode.
The WSJT-X spot table is unchanged. This only changes the New Contact panel:
it now uses WSJT-X's TX/logging mode for the QSO mode.