Open
Conversation
- Why? DeployAll is the exact method that encapsulates a lot of useful logic and can be reused to run the deploy against a folder within other tools.
- extracting DeploySingle core API method
…nfig DeployConfig represents a set of CLI args (deploy parameters) that are used for "fn deploy" DeployConfig makes method signatures shorter and simpler to read and work with
denismakogon
force-pushed
the
deploy-API
branch
from
dd16537 to
1f44533
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracting deploy core API to make it reusable outside of the Fn CLI.
Deploy API is quite useful, however, it appeared to be very coupled with the existing CLI framework.
This PR extracts core methods:
DeployAllandDeploySinglethat may be used to deploy the whole application or a single function.