This repository was archived by the owner on Mar 6, 2025. It is now read-only.
Check for missing group before using.#9
Open
queenvictoria wants to merge 2 commits intofnagel:masterfrom
Open
Conversation
Owner
|
Looks valid, but PR is outdated. Would you like to update your fork or should I adopt your changes? Thanks for your contribution! ps: I'm working on an API documentation built with YUIdocs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you instantiate with gallery:true but there is only one image then this.group isn't set and causes _getPositionInfo to fail.