Don't divide space into strips smaller than the stencil size. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This triggered a vlasiator crash in a 4 × 4 cell test run with 4 nodes, where space was subdivided into 1 × 4 cell strips. These were too small for the stencil size of 2. As an added bonus, this should speed up fsgrid setup for large simulations a little bit.
Contributor
|
Looks sensible. Has it been tested with Thiago? |
Contributor
|
Let's wait with this one until the AMR dust settles in Vlasiator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This triggered a vlasiator crash in a 4 × 4 cell test run with 4 nodes,
where space was subdivided into 1 × 4 cell strips. These were too small
for the stencil size of 2.
As an added bonus, this should speed up fsgrid setup for large
simulations a little bit.