Removes cookiecutter dependency #2360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
requested review from
cosmicBboy,
eapolinario,
kumare3,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
dosubot
bot
added
the
size:M
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
dosubot
bot
added
size:L
Collaborator
|
This is great! Can you also remove the mentions to cookiecutter from the description in https://github.com/flyteorg/flytekit-python-template? |
eapolinario
approved these changes
Apr 18, 2024
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Removes cookiecutter dependency Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * Updates requirements Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * Raise error with directory already exists Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * Lint and regenerate dev-requirements Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Jan Fiedler <jan@union.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #1665
Related to flyteorg/flyte#4418
Why are the changes needed?
This PR removes the
cookiecutterdependency from flytekit.What changes were proposed in this pull request?
This PR replaces the
cookiecuttercode with a HTTP request, extracting the files from the template, and replacing{{cookiecutter.project_name}}in the contents and file names.How was this patch tested?
I reran
pyflyte initfor every template and checked that the behavior is the same as before.