-
Notifications
You must be signed in to change notification settings - Fork 775
Add test script for GetTaskDetails #6841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Conversation
|
@machichima The change is ready. Please have a look at this. Thanks! |
|
Hi @aniket2405 , |
Signed-off-by: aniket2405 <aniketshaha2001@gmail.com>
cfaf5e5 to
c8b0aef
Compare
|
Hi @machichima |
|
Could you please do After doing so the CI test should pass |
|
@machichima |
|
@aniket2405 Please add DCO to your latest commit, then this PR is good to go! |
Signed-off-by: aniket2405 <aniketshaha2001@gmail.com>
ad9de33 to
bce9373
Compare
|
@machichima Done. Added DCO. Sorry for the delay. |
Tracking issue
Closes #6821
Why are the changes needed?
Added
test/scripts/get_task_details.shto allow for manual testing of theGetTaskDetailsendpoint using buf curl.What changes were proposed in this pull request?
How was this patch tested?
Endpoint Validation
The
GetTaskDetailsRPC endpoint is already tested in the existingTestDeployTaskintegration test which verifies:Script Validation
During development, validated the script works correctly by:
create_task.shto deploy a test taskget_task_details.shto retrieve task detailsLabels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link