feat: support cross-bucket copy and move operations#18
Merged
thetutlage merged 7 commits into2.xfrom Apr 7, 2026
Merged
Conversation
RomainLanz
force-pushed
the
feat/move-copy-other-bucket
branch
from
666efa3 to
df56700
Compare
RomainLanz
force-pushed
the
feat/move-copy-other-bucket
branch
from
df56700 to
1a49caf
Compare
Make the cross-bucket option name explicit about its purpose and remove .catch() from S3 unit tests so they expect success.
Add debug logging to S3 copy and use env-configured other bucket names instead of hardcoded non-existent bucket names.
thetutlage
requested changes
Mar 31, 2026
Member
Author
|
Should be good! 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! 👋🏻
This PR allows
copyandmoveoperations to target a different bucket instead of always operating within the same one. A newCopyMoveOptionstype extendsWriteOptionswith an optional bucket property, so users can write:Both the S3 and GCS drivers have been updated to use this destination bucket for the target while keeping the current bucket as the source. The change is fully backward compatible since omitting bucket behaves exactly as before.
Integration tests have been added for both S3 and GCS that pass the bucket option explicitly with the same bucket to validate the code path.
For S3 specifically, unit tests subclass the driver to verify that
CopyObjectCommandreceives the correctBucketandCopySourcevalues when a different destination bucket is provided.True cross-bucket integration tests with a second real bucket are not included as they would require additional CI configuration.