Fix heic color space handling on iOS#358
Open
anthonyVuAtPropertyMe wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix iOS HEIC encoding with proper color space handling and error validation
Problem
JPEG to HEIC conversion on iOS was silently failing. The compression would appear to succeed, but the HEIC file was never actually written to disk. Additionally, the code lacked proper error handling and memory management for color space resources.
Root Cause
The issue was a subtle Objective-C compiler optimization. In
CompressFileHandler.m, the return value ofwriteToURL:atomically:was ignored, causing the compiler to optimize away the file write call entirely as "dead code" since the result didn't affect anything downstream. This meant the[data writeToURL:...]call was never executed in the compiled binary.Changes
CompressFileHandler.m
BOOL successvariableCompressHandler.m
Impact
✅ JPEG to HEIC conversion now successfully creates files on iOS
✅ Proper error reporting to callers about operation success/failure
✅ Prevents potential memory leaks from color space resources
✅ Better debugging with error messages