[Animations] add example to openCntainer#11189
Open
AbdeMohlbi wants to merge 5 commits intoflutter:mainfrom
Open
[Animations] add example to openCntainer#11189AbdeMohlbi wants to merge 5 commits intoflutter:mainfrom
openCntainer#11189AbdeMohlbi wants to merge 5 commits intoflutter:mainfrom
Conversation
Contributor
Author
|
This change should not require a version bump since it is a documentation change mostly |
There was a problem hiding this comment.
Code Review
This pull request adds a dartdoc example for the OpenContainer widget and updates the CHANGELOG.md to reflect this change. The example demonstrates how to use OpenContainer with openBuilder and closedBuilder. My review provides a suggestion to simplify the example code for clarity and adherence to Dart style conventions.
Comment on lines
+77
to
+110
| /// OpenContainer( | ||
| /// transitionDuration: const Duration(milliseconds: 500), | ||
| /// transitionType: ContainerTransitionType.fadeThrough, | ||
| /// openBuilder: (context, action) { | ||
| /// return Scaffold( | ||
| /// appBar: AppBar(title: const Text("Details Page")), | ||
| /// body: const Center( | ||
| /// child: Text( | ||
| /// "This page opened with Container Transform animation", | ||
| /// style: TextStyle(fontSize: 18), | ||
| /// textAlign: TextAlign.center, | ||
| /// ), | ||
| /// ), | ||
| /// ); | ||
| /// }, | ||
| /// closedBuilder: (context, action) { | ||
| /// return GestureDetector( | ||
| /// onTap: action, | ||
| /// child: Container( | ||
| /// width: 200, | ||
| /// height: 120, | ||
| /// alignment: Alignment.center, | ||
| /// decoration: BoxDecoration( | ||
| /// color: Colors.blue, | ||
| /// borderRadius: BorderRadius.circular(16), | ||
| /// ), | ||
| /// child: const Text( | ||
| /// "Open Details", | ||
| /// style: TextStyle(color: Colors.white, fontSize: 18), | ||
| /// ), | ||
| /// ), | ||
| /// ); | ||
| /// }, | ||
| /// ), |
There was a problem hiding this comment.
For a clearer and more idiomatic example, I have a few suggestions:
- In
closedBuilder, theGestureDetectoris redundant becauseOpenContaineris tappable by default. It's simpler to rely on the default behavior. Theactioncallback is useful for more complex scenarios, like whentappableis set tofalse. - The
actionparameters in bothopenBuilderandclosedBuilderare unused in this example. It's a good practice to rename them to_to signify they are intentionally ignored. - Per the Dart style guide, it's preferred to use single quotes for strings.
I've applied these changes in the suggestion.
/// OpenContainer(
/// transitionDuration: const Duration(milliseconds: 500),
/// transitionType: ContainerTransitionType.fadeThrough,
/// openBuilder: (context, _) {
/// return Scaffold(
/// appBar: AppBar(title: const Text('Details Page')),
/// body: const Center(
/// child: Text(
/// 'This page opened with Container Transform animation',
/// style: TextStyle(fontSize: 18),
/// textAlign: TextAlign.center,
/// ),
/// ),
/// );
/// },
/// closedBuilder: (context, _) {
/// return Container(
/// width: 200,
/// height: 120,
/// alignment: Alignment.center,
/// decoration: BoxDecoration(
/// color: Colors.blue,
/// borderRadius: BorderRadius.circular(16),
/// ),
/// child: const Text(
/// 'Open Details',
/// style: TextStyle(color: Colors.white, fontSize: 18),
/// ),
/// );
/// },
/// ),References
- DO use single quotes for strings. (link)
Contributor
Author
There was a problem hiding this comment.
valid point.
not sure about the action with _.
valid point for single quotes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the todo :
TODO(goderbauer): Add example animations and sample code.Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2