Skip to content

[Animations] add example to openCntainer#11189

Open
AbdeMohlbi wants to merge 5 commits intoflutter:mainfrom
AbdeMohlbi:fix_todo_in_open_container
Open

[Animations] add example to openCntainer#11189
AbdeMohlbi wants to merge 5 commits intoflutter:mainfrom
AbdeMohlbi:fix_todo_in_open_container

Conversation

@AbdeMohlbi
Copy link
Contributor

@AbdeMohlbi AbdeMohlbi commented Mar 6, 2026

Fixes the todo : TODO(goderbauer): Add example animations and sample code.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@github-actions github-actions bot added p: animations triage-framework Should be looked at in framework triage labels Mar 6, 2026
@AbdeMohlbi AbdeMohlbi added the override: no versioning needed Override the check requiring version bumps for most changes label Mar 6, 2026
@AbdeMohlbi
Copy link
Contributor Author

This change should not require a version bump since it is a documentation change mostly

@AbdeMohlbi AbdeMohlbi marked this pull request as ready for review March 6, 2026 09:18
@AbdeMohlbi AbdeMohlbi requested a review from hannah-hyj as a code owner March 6, 2026 09:18
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a dartdoc example for the OpenContainer widget and updates the CHANGELOG.md to reflect this change. The example demonstrates how to use OpenContainer with openBuilder and closedBuilder. My review provides a suggestion to simplify the example code for clarity and adherence to Dart style conventions.

Comment on lines +77 to +110
/// OpenContainer(
/// transitionDuration: const Duration(milliseconds: 500),
/// transitionType: ContainerTransitionType.fadeThrough,
/// openBuilder: (context, action) {
/// return Scaffold(
/// appBar: AppBar(title: const Text("Details Page")),
/// body: const Center(
/// child: Text(
/// "This page opened with Container Transform animation",
/// style: TextStyle(fontSize: 18),
/// textAlign: TextAlign.center,
/// ),
/// ),
/// );
/// },
/// closedBuilder: (context, action) {
/// return GestureDetector(
/// onTap: action,
/// child: Container(
/// width: 200,
/// height: 120,
/// alignment: Alignment.center,
/// decoration: BoxDecoration(
/// color: Colors.blue,
/// borderRadius: BorderRadius.circular(16),
/// ),
/// child: const Text(
/// "Open Details",
/// style: TextStyle(color: Colors.white, fontSize: 18),
/// ),
/// ),
/// );
/// },
/// ),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For a clearer and more idiomatic example, I have a few suggestions:

  • In closedBuilder, the GestureDetector is redundant because OpenContainer is tappable by default. It's simpler to rely on the default behavior. The action callback is useful for more complex scenarios, like when tappable is set to false.
  • The action parameters in both openBuilder and closedBuilder are unused in this example. It's a good practice to rename them to _ to signify they are intentionally ignored.
  • Per the Dart style guide, it's preferred to use single quotes for strings.

I've applied these changes in the suggestion.

/// OpenContainer(
///   transitionDuration: const Duration(milliseconds: 500),
///   transitionType: ContainerTransitionType.fadeThrough,
///   openBuilder: (context, _) {
///     return Scaffold(
///       appBar: AppBar(title: const Text('Details Page')),
///       body: const Center(
///         child: Text(
///           'This page opened with Container Transform animation',
///           style: TextStyle(fontSize: 18),
///           textAlign: TextAlign.center,
///         ),
///       ),
///     );
///   },
///   closedBuilder: (context, _) {
///     return Container(
///       width: 200,
///       height: 120,
///       alignment: Alignment.center,
///       decoration: BoxDecoration(
///         color: Colors.blue,
///         borderRadius: BorderRadius.circular(16),
///       ),
///       child: const Text(
///         'Open Details',
///         style: TextStyle(color: Colors.white, fontSize: 18),
///       ),
///     );
///   },
/// ),
References
  1. DO use single quotes for strings. (link)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valid point.
not sure about the action with _.
valid point for single quotes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

override: no versioning needed Override the check requiring version bumps for most changes p: animations triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant