[shared_preferences_tool] Update dependencies and fix deprecation #10560
Conversation
| }); | ||
| }); | ||
| </script> | ||
| <script src="flutter_bootstrap.js" async></script> |
There was a problem hiding this comment.
I also updated this, which was also a deprecation.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates dependencies for the shared_preferences_tool package, including devtools_app_shared, devtools_extensions, build_runner, and mockito. It also updates the Dart SDK constraint. As part of these updates, several deprecations are addressed: the requiresRunningApplication parameter is removed from DevToolsExtension widgets in tests, and the web app initialization in index.html is updated to use the modern flutter_bootstrap.js script. The changes are logical and correctly address the dependency updates and deprecations. I have one suggestion to make the changelog entry more descriptive.
| flutter_test: | ||
| sdk: flutter | ||
| mockito: 5.4.4 | ||
| mockito: 5.6.1 |
There was a problem hiding this comment.
What new build_runner and mockito features are you using that require narrowing the compatible version range?
There was a problem hiding this comment.
none, just felt like updating them since I was already updating devtools_app_shared and devtools_extensions.
There was a problem hiding this comment.
There was a problem hiding this comment.
Understood. I can remove the updates, but I don't think they fall in either pushing transitive dependency and version lock issues. These are dev_dependencies and this package (shared_preference_tool) is actually a stand alone web app that is build and bundled to be used by DevTools. This will not affect the client's dependency tree at all.
There was a problem hiding this comment.
I don't think they fall in either
pushing transitive dependencyandversion lockissues.
I'm aware that the two specific examples listed there don't apply here, but those are just common examples. The policy is the first sentence:
Our general policy is not to update the minimum version of a dependency beyond what the package requires.
This will not affect the client's dependency tree at all.
Sure, but it's still artificially narrowing the range of possible resolution. The policy isn't that we artificially narrow ranges by default unless there's a specific downside, it's that we don't narrow ranges unless there's a specific reason to do so.
I just noticed that this is still using a pinned version of mockito though, which we don't need to do any more; I thought we updated all instances of that, but maybe the PR to add this package was still in flight when that happened. It would be good to change this to ^5.4.4 instead of 5.4.4.
There was a problem hiding this comment.
Perfect! Gonna unpin the version.
it's that we don't narrow ranges unless there's a specific reason to do so.
Got it! It makes sense. I'll revert this and unpin the version. This will also remove the generated code changes.
tarrinneal
added
the
autosubmit
flutter/packages@33a9a81...338ecd3 2025-12-09 adsonpleal@gmail.com [shared_preferences_tool] Update dependencies and fix deprecation (flutter/packages#10560) 2025-12-08 47866232+chunhtai@users.noreply.github.com [ci] Use manual trigger for go_router_batch workflow for testing purp… (flutter/packages#10475) 2025-12-08 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump camerax_version from 1.5.1 to 1.5.2 in /packages/camera/camera_android_camerax/android (flutter/packages#10582) 2025-12-08 engine-flutter-autoroll@skia.org Roll Flutter from 5b87203 to b2de367 (38 revisions) (flutter/packages#10587) 2025-12-08 10687576+bparrishMines@users.noreply.github.com [camera_android_camerax] Removes internal native library Dart proxy (flutter/packages#10536) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Update the dependencies and fix deprecations.
Issues:
flutter/flutter#166602
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3