[google_maps_flutter_ios] Add Advanced marker support by jokerttu · Pull Request #10508 · flutter/packages

jokerttu · 2025-11-24T14:39:35Z

This PR adds Advanced markers support to the iOS implementation of google_maps_flutter.
Approved combined PR: #7882
Approved and merged platform interface PR: #9737
Issue: flutter/flutter#155526

Blocker:
GMSAdvancedMarker is not rendered when the marker icon is a GMSPinImage instance. Tracking issue:
https://issuetracker.google.com/issues/370536110

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

stuartmorgan-g · 2026-01-06T19:00:37Z

Picking up the discussion from the main issue here: do you have a link to the tracking issue for the blocker here ("an issue with the GMSPinImage not rendering on the map", per this comment)? As noted in that discussion, the link is to a long-closed issue.

jokerttu · 2026-01-08T10:27:23Z

Picking up the discussion from the main issue here: do you have a link to the tracking issue for the blocker here ("an issue with the GMSPinImage not rendering on the map", per this comment)? As noted in that discussion, the link is to a long-closed issue.

Added tracking issue information to this PR description:
~~https://issuetracker.google.com/issues/474141340~~
Edit: the "long-closed issue" is now re-opened: https://issuetracker.google.com/issues/370536110

packages/google_maps_flutter/google_maps_flutter_ios/lib/src/messages.g.dart

jokerttu · 2026-02-19T15:24:23Z

@stuartmorgan-g
As this iOS implementation package still has an issue with Advanced Marker rendering when the marker icon is created using PinConfig (tracked here: https://issuetracker.google.com/issues/370536110).

Note that Advanced Markers without any customizations (without PinConfig icon type), or those using a custom image asset, render correctly. The issue only affects markers that use GMSPinImage to customize the marker in native iOS code.

We could still publish, but it must be clearly communicated to developers that PinConfig icons are not supported and are affected by this issue. (Related comment at #7882 (comment))

Since PinConfig and AdvancedMarker are defined in packages/google_maps_flutter/google_maps_flutter_platform_interface (and not in this iOS implementation package), what would be the best place to document this behavior so that Devs really are aware of this?

Option 1:
Add an assert in _platformMarkerFromMarker conversion method to ensure marker.icon is not PinConfig.

Option 2:
Throw an UnsupportedError in _platformMarkerFromMarker conversion method if marker.icon is PinConfig.

Option 3:
Just log a warning to the console.
(This would most likely cause unnecessary issue reports)

I’ll also create a separate issue describing the issue and link it to the code under TODO

Additionally, this should be documented in the iOS implementation package’s README.md?

stuartmorgan-g · 2026-02-19T16:20:58Z

Since PinConfig and AdvancedMarker are defined in packages/google_maps_flutter/google_maps_flutter_platform_interface (and not in this iOS implementation package), what would be the best place to document this behavior so that Devs really are aware of this?

We'll have to bypass our usual guidance against platform-specific docs in the platform interface in this case, and document it on PinConfig.

Option 1: Add an assert in _platformMarkerFromMarker conversion method to ensure marker.icon is not PinConfig.

Option 2: Throw an UnsupportedError in _platformMarkerFromMarker conversion method if marker.icon is PinConfig.

Option 3: Just log a warning to the console. (This would most likely cause unnecessary issue reports)

I don't think we should do anything at a code level, because the behavior isn't in code that we control. Let's say we ship an UnsupportedError... then a week later, a bugfix release of the Google Maps iOS SDK goes out that fixes the issue. Now google_maps_flutter is broken even though the SDK isn't.

I think we should just put a prominent comment on the PinConfig class and constructor, and on the pinConfig factory method. We should phrase it in such a way that it won't be actively wrong if we haven't removed/updated it yet once the issue is fixed; something like:

WARNING: On iOS, using a PinConfig may result in the marker not showing. For details and updates, see
https://issuetracker.google.com/issues/370536110. If this issue has not been fixed in the version of the
Google Maps SDK you are using, consider using an asset or bitmap for customization on iOS.

Additionally, this should be documented in the iOS implementation package’s README.md?

This is severe enough that I would put it here rather than in the implementation package, especially since we still mostly haven't "federated" the README platform details yet for this plugin.

gemini-code-assist

Code Review

This pull request introduces advanced marker support to the iOS implementation of google_maps_flutter. It includes updates to the CHANGELOG.md, modifications to integration tests to cover advanced marker clustering and pin configurations, and new example pages demonstrating advanced marker icons and collision behavior. The core changes involve updating Pigeon messages to include PlatformMarkerCollisionBehavior and PlatformMarkerType, and modifying the FGMMarkersController to handle advanced markers based on the markerType configuration. The FGMImageUtils.m file has been updated to support PinConfig for advanced marker icons.

...google_maps_flutter/google_maps_flutter_ios_shared_code/lib/src/google_maps_flutter_ios.dart

...gle_maps_flutter_ios/Sources/google_maps_flutter_ios/google_maps_flutter_pigeon_messages.g.m

packages/google_maps_flutter/google_maps_flutter_ios_shared_code/lib/src/messages.g.dart

...gle_maps_flutter_ios/Sources/google_maps_flutter_ios/google_maps_flutter_pigeon_messages.g.m

.../google_maps_flutter/google_maps_flutter_ios_shared_code/example/lib/example_google_map.dart

packages/google_maps_flutter/google_maps_flutter_ios_shared_code/lib/src/messages.g.dart

#11100) Add iOS warning for PinConfig usage in BitmapDescriptor iOS implementation for Advanced Markers: #10508 Related issue: flutter/flutter#155526 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

stuartmorgan-g

Generally looks good, just small comments.

What changes were in that last force-push? It came in when I was almost done reviewing, and since it's a force-push I can't see diffs relative to where I had reviewed.

..._flutter_ios/Sources/google_maps_flutter_ios/include/google_maps_flutter_ios/FGMImageUtils.h

...sdk10/example/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

...aps_flutter/google_maps_flutter_ios/example/ios/RunnerTests/ClusterManagersControllerTests.m

stuartmorgan-g · 2026-02-23T16:04:55Z

...ogle_maps_flutter/google_maps_flutter_ios/example/ios/RunnerTests/ExtractIconFromDataTests.m

+      FGMIconFromBitmap([FGMPlatformBitmap makeWithBitmap:pinConfig], assetProvider, screenScale);
+
+  // PinConfig returns nil on iOS versions without GMSPinImageOptions support (< iOS 16.0).
+  // On simulators, GMSPinImage may also return a zero-dimension image. Both cases are acceptable


Out of curiosity, do we know why this happens in simulators, or is it just an undocumented SDK behavior?

I updated the comment to better explain the reasoning behind this logic.

...ter_ios/ios/google_maps_flutter_ios/Sources/google_maps_flutter_ios/FGMGoogleMapController.m

stuartmorgan-g · 2026-02-23T16:35:50Z

packages/google_maps_flutter/google_maps_flutter_ios/lib/src/google_maps_flutter_ios.dart

+        PlatformMarkerCollisionBehavior.optionalAndHidesLowerPriority,
+      MarkerCollisionBehavior.requiredAndHidesOptional =>
+        PlatformMarkerCollisionBehavior.requiredAndHidesOptional,
+    };


This must have a fallback behavior (either a default value, or null, whichever makes more sense in this case) to handle changes in the platform interface. Search for // ignore: dead_code in this file for examples to follow.

this now defaults to the default value PlatformMarkerCollisionBehavior.requiredDisplay;

stuartmorgan-g · 2026-02-23T16:37:25Z

packages/google_maps_flutter/google_maps_flutter_ios/lib/src/google_maps_flutter_ios.dart

+                borderColor: borderColor,
+              ),
+            );
+        }


Same here; this code needs some kind of handling of the case where a new glyph type is added to the platform interface as a non-breaking change (even if it's just throwing an UnimplementedError).

Will throw UnimplementedError for unimplemented glyph types

stuartmorgan-g · 2026-02-23T16:38:43Z

packages/google_maps_flutter/google_maps_flutter_ios/lib/src/google_maps_flutter_ios.dart

+  return switch (markerType) {
+    MarkerType.marker => PlatformMarkerType.marker,
+    MarkerType.advancedMarker => PlatformMarkerType.advancedMarker,
+  };


Needs fallback handling, in case a third marker type is ever added.

Will throw UnimplementedError for marker types not yet implemented.
throw UnimplementedError('MarkerType "$markerType" has not been implemented');

packages/google_maps_flutter/google_maps_flutter_ios/pigeons/messages.dart

...ogle_maps_flutter/google_maps_flutter_ios_sdk10/example/ios/Runner.xcodeproj/project.pbxproj

…rsion ^2.14.2

… interface

jokerttu · 2026-02-26T13:25:45Z

@stuartmorgan-g

What changes were in that last force-push? It came in when I was almost done reviewing, and since it's a force-push I can't see diffs relative to where I had reviewed.

Sorry for the late response. You didn't miss anything in the earlier rebase.
And the latest rebase/force-push only reverts the package-related changes as requested.
All other review comments have been addressed in the following separate commits:
https://github.com/flutter/packages/pull/10508/commits

stuartmorgan-g

LGTM! I'm going to go ahead and land this, and then we can roll out the app-level support (and hope that the SDK issue with PinConfig will be resolved soon).

github-actions bot added p: google_maps_flutter platform-ios labels Nov 24, 2025

jokerttu force-pushed the feature/advanced_markers_google_maps_flutter_ios branch from 8f811e9 to 26fd75a Compare November 24, 2025 15:16

jokerttu force-pushed the feature/advanced_markers_google_maps_flutter_ios branch 3 times, most recently from 16c74d8 to df35a62 Compare January 14, 2026 14:08

jokerttu force-pushed the feature/advanced_markers_google_maps_flutter_ios branch 2 times, most recently from 2c08201 to b1b0038 Compare February 18, 2026 16:57

stuartmorgan-g reviewed Feb 18, 2026

View reviewed changes

packages/google_maps_flutter/google_maps_flutter_ios/lib/src/messages.g.dart Outdated Show resolved Hide resolved

jokerttu force-pushed the feature/advanced_markers_google_maps_flutter_ios branch from b1b0038 to da25bc6 Compare February 19, 2026 15:44

jokerttu force-pushed the feature/advanced_markers_google_maps_flutter_ios branch from da25bc6 to d8397ec Compare February 20, 2026 14:14

jokerttu marked this pull request as ready for review February 23, 2026 10:12

jokerttu requested review from LongCatIsLooong and vashworth as code owners February 23, 2026 10:12

jokerttu force-pushed the feature/advanced_markers_google_maps_flutter_ios branch from d8397ec to 6a2e5a9 Compare February 23, 2026 10:12

gemini-code-assist bot reviewed Feb 23, 2026

View reviewed changes

jokerttu mentioned this pull request Feb 23, 2026

[google_maps_flutter_platform_interface] Add iOS warning for PinConfig #11100

Merged

11 tasks

jokerttu force-pushed the feature/advanced_markers_google_maps_flutter_ios branch from 7eac3ce to 911dfa1 Compare February 23, 2026 11:58

jokerttu force-pushed the feature/advanced_markers_google_maps_flutter_ios branch from 911dfa1 to 9d2bacd Compare February 23, 2026 16:49

jokerttu requested a review from stuartmorgan-g February 23, 2026 16:50

stuartmorgan-g requested changes Feb 23, 2026

View reviewed changes

jokerttu added 3 commits February 26, 2026 12:31

[google_maps_flutter_ios] Add advanced marker support

0e58e08

chore: update google_maps_flutter_platform_interface dependency to ve…

04ab1eb

…rsion ^2.14.2

improvements

caf8fa6

jokerttu force-pushed the feature/advanced_markers_google_maps_flutter_ios branch from 9d2bacd to caf8fa6 Compare February 26, 2026 13:05

jokerttu added 2 commits February 26, 2026 15:12

Update UnimplementedError message to match the style used in platform…

92f1ad7

… interface

Add missing import for FGMConversionUtils

abc319a

jokerttu requested a review from stuartmorgan-g February 26, 2026 13:54

stuartmorgan-g approved these changes Mar 5, 2026

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 5, 2026

auto-submit bot merged commit bf3a29c into flutter:main Mar 5, 2026
81 checks passed

jokerttu deleted the feature/advanced_markers_google_maps_flutter_ios branch March 6, 2026 08:07

Conversation

jokerttu commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

stuartmorgan-g commented Jan 6, 2026

Uh oh!

jokerttu commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jokerttu commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g commented Feb 19, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

jokerttu Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stuartmorgan-g Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

jokerttu Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

jokerttu Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

jokerttu Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jokerttu commented Feb 26, 2026

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jokerttu commented Nov 24, 2025 •

edited

Loading

jokerttu commented Jan 8, 2026 •

edited

Loading

jokerttu commented Feb 19, 2026 •

edited

Loading

jokerttu Feb 26, 2026 •

edited

Loading