Skip to content

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Nov 20, 2025

…oses and adjust release branch name

as title

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@chunhtai chunhtai marked this pull request as ready for review November 20, 2025 00:03
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These specific changes LGTM, but there is an open question about how release-<foo> branches are going to be maintained that will block any deployment of this system.

@chunhtai
Copy link
Contributor Author

chunhtai commented Dec 8, 2025

I think I have addressed the concern in branch management, thanks for the feedback. I will proceed to merge this PR

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 8, 2025

autosubmit label was removed for flutter/packages/10475, because - The status or check suite Linux_android android_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2025
@auto-submit auto-submit bot merged commit 4ac035b into flutter:main Dec 8, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 9, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Dec 9, 2025
flutter/packages@33a9a81...338ecd3

2025-12-09 adsonpleal@gmail.com [shared_preferences_tool] Update
dependencies and fix deprecation (flutter/packages#10560)
2025-12-08 47866232+chunhtai@users.noreply.github.com [ci] Use manual
trigger for go_router_batch workflow for testing purp…
(flutter/packages#10475)
2025-12-08 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump camerax_version from 1.5.1 to 1.5.2 in
/packages/camera/camera_android_camerax/android (flutter/packages#10582)
2025-12-08 engine-flutter-autoroll@skia.org Roll Flutter from
5b87203 to b2de367 (38 revisions) (flutter/packages#10587)
2025-12-08 10687576+bparrishMines@users.noreply.github.com
[camera_android_camerax] Removes internal native library Dart proxy
(flutter/packages#10536)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants