Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

### Changed

- Made log file `dash.log` (instead of `flutter.log`).
- Made log file `dash.log` (instead of `flutter.log`). (#8638)

### Removed

Expand Down
32 changes: 30 additions & 2 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,36 @@ intellijPlatform {
ignoredProblemsFile.set(project.file("verify-ignore-problems.txt"))

ides {
recommended()
// `singleIdeVersion` is only intended for use by GitHub actions to enable deleting instances of IDEs after testing.
if (project.hasProperty("singleIdeVersion")) {
val singleIdeVersion = project.property("singleIdeVersion") as String
select {
types = listOf(IntelliJPlatformType.AndroidStudio)
channels = listOf(ProductRelease.Channel.RELEASE)
sinceBuild = singleIdeVersion
untilBuild = "$singleIdeVersion.*"
}
} else {
recommended()
}
}
}
}

// If we don't delete old versions of the IDE during `verifyPlugin`, then GitHub action bots can run out of space.
tasks.withType<VerifyPluginTask> {
if (project.hasProperty("singleIdeVersion")) {
doLast {
ides.forEach { ide ->
if (ide.exists()) {
// This isn't a clean deletion because gradle has internal logic for tagging that it has downloaded something, and the tagging
// isn't deleted. So if we were to run `./gradlew verifyPlugin -PsingleIdeVersion=<someVersion` twice in a row, the second time
// would fail due to gradle thinking that there should be an IDE at a place it recorded from the last run.
println("Deleting IDE directory at ${ide.path}")
val result = ide.deleteRecursively()
println("IDE was deleted? $result")
}
}
}
}
}
Expand Down Expand Up @@ -418,4 +447,3 @@ tasks.withType<ProcessResources>().configureEach {
exclude("jxbrowser/jxbrowser.properties")
}
}

1 change: 1 addition & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

ideaVersion=2025.2.1.5
dartPluginVersion= 252.25557.23
# Also update the versions for verify checks in tool/github.sh.
sinceBuild=243
untilBuild=253.*
javaVersion=21
Expand Down
16 changes: 15 additions & 1 deletion tool/github.sh
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,24 @@ elif [ "UNIT_TEST_BOT" = "$BOT" ] ; then

elif [ "VERIFY_BOT" = "$BOT" ] ; then
# Run the verifier
echo "Check on space before verifyPluginProjectConfiguration\n"
df -h
./gradlew verifyPluginProjectConfiguration
echo "Check on space before verifyPluginStructure\n"
df -h
./gradlew verifyPluginStructure
echo "Check on space before verifyPluginSignature\n"
df -h
./gradlew verifyPluginSignature
./gradlew verifyPlugin

for version in 243 251 252; do
echo "Check on space before verifyPlugin for $version\n"
df -h
./gradlew verifyPlugin -PsingleIdeVersion=$version
done

echo "Check on space after verifyPlugin"
df -h

elif [ "INTEGRATION_BOT" = "$BOT" ]; then
# Run the integration tests
Expand Down