Add toggle to filter out SOCKET rows in Network screen#9698
Conversation
|
Hi @rishika0212, thank you for the contribution. We actually already have a convention within DevTools to add toggle filters like this. Please see #9460 (comment) for details, I added some code pointers on the issue detailing how to integrate with the existing toggle filter mechanism. If you can adjust this PR to follow the pattern described there, we'd be happy to review this change. Thanks! |
Thanks for the pointers! |
Co-authored-by: Kenzie Davisson <43759233+kenzieschmoll@users.noreply.github.com>
Co-authored-by: Kenzie Davisson <43759233+kenzieschmoll@users.noreply.github.com>
…directly as suggested in review.
…hika0212/devtools into network-socket-filter-toggle
* Add toggle to filter out socket rows in Network screen * fix: add toggle filter to hide HTTP profiler tcp sockets in Network screen * Removed visibleForTesting annotation and fixed analyzer warnings * fix: addresses PR review feedbacks * Update packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md Co-authored-by: Kenzie Davisson <43759233+kenzieschmoll@users.noreply.github.com> * Update packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md Co-authored-by: Kenzie Davisson <43759233+kenzieschmoll@users.noreply.github.com> * Refactor test to use activeFilter.value.settingFilters and set value directly as suggested in review. * fixed format --------- Co-authored-by: Kenzie Davisson <43759233+kenzieschmoll@users.noreply.github.com>
Description:
This PR adds a toolbar toggle to the Network screen, allowing users to hide TCP socket rows associated with HTTP profiled requests. When enabled, only HTTP requests are shown, resulting in a cleaner and more focused view. This feature addresses user feedback and resolves #9460.
Before:
All HTTP and socket rows were shown, making the table noisy.
After:
Users can toggle to hide socket rows, showing only HTTP requests.
Issue fixed:
Fixes #9460
Release notes:
Added a note to NEXT_RELEASE_NOTES.md.
Pre-launch Checklist
///).If you need help, consider asking for help on Discord.