Fix cancelled HTTP requests showing as Pending in DevTools Network tab#9685
Open
rishika0212 wants to merge 1 commit intoflutter:masterfrom
Open
Fix cancelled HTTP requests showing as Pending in DevTools Network tab#9685rishika0212 wants to merge 1 commit intoflutter:masterfrom
rishika0212 wants to merge 1 commit intoflutter:masterfrom
Conversation
srawlins
approved these changes
Mar 6, 2026
Contributor
srawlins
left a comment
There was a problem hiding this comment.
This code looks great; thanks for the PR! I'd like to test manually before landing.
| super.shrinkWrap, | ||
| super.padding, | ||
| super.scrollCacheExtent, | ||
| super.cacheExtent, |
Contributor
There was a problem hiding this comment.
CC @elliette ; from the PR description:
Update CustomPointerScrollView to use cacheExtent so the project compiles with the current Flutter SDK
bkonyi
approved these changes
Mar 6, 2026
| return false; | ||
| } | ||
|
|
||
| return _hasError |
Contributor
There was a problem hiding this comment.
Ubernit: We can simply negate the entire expression rather than doing it twice
return !(_hasError
? _request.isRequestComplete
: _request.isResponseComplete);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where cancelled HTTP requests appear as "Pending" in the DevTools Network tab.
When a request is aborted (for example using
HttpClientRequest.abortor Dio cancellation), DevTools keeps the request in a Pending state because no response is received. This change detects such cases and displays the request status as "Cancelled" instead.Changes
HttpRequestDatainProgressnullfor cancelled requestsCustomPointerScrollViewto usecacheExtentso the project compiles with the current Flutter SDKAll existing network tests pass locally.
Fixes: #9593
Pre-launch Checklist
If you need help, consider asking for help on Discord.