refactor: Enhance image format validation and optimize InputImage con… by bensonarafat · Pull Request #847 · flutter-ml/google_ml_kit_flutter

bensonarafat · 2026-02-27T08:04:36Z

…version

…ods for better resource management

bensonarafat · 2026-02-27T11:59:35Z

@fbernaly
Here is the Updated PR
And I am closing #732

Copilot

Pull request overview

This PR refactors Android-side InputImage creation to broaden supported camera image formats (notably YUV_420_888) and updates the example camera view to validate/prepare multi-plane image bytes.

Changes:

Update multiple Android detectors to create an InputImageConverter per request and close it when ML Kit processing completes.
Extend InputImageConverter to handle additional byte-based image formats, including a new YUV_420_888 path.
Update the example camera_view.dart to accept more Android formats and to concatenate bytes from multi-plane CameraImages.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
packages/google_mlkit_text_recognition/android/src/main/kotlin/com/google_mlkit_text_recognition/TextRecognizer.kt	Switches to per-call converter instance and closes on completion.
packages/google_mlkit_subject_segmentation/android/src/main/kotlin/com/google_mlkit_subject_segmentation/SubjectSegmenter.kt	Switches to per-call converter instance and closes on completion.
packages/google_mlkit_selfie_segmentation/android/src/main/kotlin/com/google_mlkit_selfie_segmentation/SelfieSegmenter.kt	Switches to per-call converter instance and closes on completion.
packages/google_mlkit_pose_detection/android/src/main/kotlin/com/google_mlkit_pose_detection/PoseDetector.kt	Switches to per-call converter instance and closes on completion.
packages/google_mlkit_face_mesh_detection/android/src/main/kotlin/com/google_mlkit_face_mesh_detection/FaceMeshDetector.kt	Switches to per-call converter instance and closes on completion.
packages/google_mlkit_face_detection/android/src/main/kotlin/com/google_mlkit_face_detection/FaceDetector.kt	Switches to per-call converter instance and closes on completion.
packages/google_mlkit_barcode_scanning/android/src/main/kotlin/com/google_mlkit_barcode_scanning/BarcodeScanner.kt	Switches to per-call converter instance and closes on completion.
packages/google_mlkit_commons/android/src/main/kotlin/com/google_mlkit_commons/InputImageConverter.kt	Adds new byte-format handling (incl. `YUV_420_888`) and introduces closeable resources.
packages/example/lib/vision_detector_views/camera_view.dart	Expands Android format validation and concatenates multi-plane bytes for `InputImage.fromBytes`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...google_mlkit_commons/android/src/main/kotlin/com/google_mlkit_commons/InputImageConverter.kt

...text_recognition/android/src/main/kotlin/com/google_mlkit_text_recognition/TextRecognizer.kt

...google_mlkit_commons/android/src/main/kotlin/com/google_mlkit_commons/InputImageConverter.kt

...gmentation/android/src/main/kotlin/com/google_mlkit_subject_segmentation/SubjectSegmenter.kt

...barcode_scanning/android/src/main/kotlin/com/google_mlkit_barcode_scanning/BarcodeScanner.kt

...google_mlkit_commons/android/src/main/kotlin/com/google_mlkit_commons/InputImageConverter.kt

...mlkit_pose_detection/android/src/main/kotlin/com/google_mlkit_pose_detection/PoseDetector.kt

packages/example/lib/vision_detector_views/camera_view.dart

fbernaly · 2026-02-27T20:20:56Z

@bensonarafat : address Copilot's comments

…code, selfie segmentation, and subject segmentation classes

bensonarafat · 2026-02-27T21:39:53Z

@fbernaly
You can review it again or ask @copilot code review[agent]

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/example/lib/vision_detector_views/camera_view.dart

...google_mlkit_commons/android/src/main/kotlin/com/google_mlkit_commons/InputImageConverter.kt

fbernaly · 2026-02-27T21:58:47Z

@bensonarafat : Address this new comments. Thanks.

…le_mlkit_commons/InputImageConverter.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…onversion to use reported format

bensonarafat · 2026-02-27T22:25:16Z

@fbernaly done

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...google_mlkit_commons/android/src/main/kotlin/com/google_mlkit_commons/InputImageConverter.kt

packages/example/lib/vision_detector_views/camera_view.dart

…le_mlkit_commons/InputImageConverter.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fbernaly · 2026-02-27T22:32:53Z

@bensonarafat : new comments

bensonarafat · 2026-02-27T22:34:17Z

on it

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/example/lib/vision_detector_views/camera_view.dart

...google_mlkit_commons/android/src/main/kotlin/com/google_mlkit_commons/InputImageConverter.kt

…le_mlkit_commons/InputImageConverter.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…eConverter

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/example/lib/vision_detector_views/camera_view.dart

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…raView

bensonarafat · 2026-02-28T05:47:12Z

@fbernaly request it

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/example/lib/vision_detector_views/camera_view.dart

fbernaly · 2026-03-02T17:45:53Z

@bensonarafat: ^^

bensonarafat · 2026-03-02T17:52:38Z

@fbernaly
Let me look at it now

…mplify buffer return

bensonarafat · 2026-03-02T18:04:27Z

@fbernaly request

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/example/lib/vision_detector_views/camera_view.dart

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

...barcode_scanning/android/src/main/kotlin/com/google_mlkit_barcode_scanning/BarcodeScanner.kt

...h_detection/android/src/main/kotlin/com/google_mlkit_face_mesh_detection/FaceMeshDetector.kt

...mlkit_pose_detection/android/src/main/kotlin/com/google_mlkit_pose_detection/PoseDetector.kt

…Detector, and PoseDetector

…hDetector, and PoseDetector

bensonarafat · 2026-03-02T19:08:33Z

done

bensonarafat added 2 commits February 27, 2026 09:02

refactor: Enhance image format validation and optimize InputImage con…

8464848

…version

refactor: Replace direct InputImageConverter calls with instance meth…

7b6cd8a

…ods for better resource management

bensonarafat marked this pull request as ready for review February 27, 2026 11:57

fbernaly requested a review from Copilot February 27, 2026 19:29

Copilot started reviewing on behalf of fbernaly February 27, 2026 19:29 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

refactor: Simplify InputImageConverter usage in pose, face, text, bar…

5a07f2c

…code, selfie segmentation, and subject segmentation classes

bensonarafat requested a review from fbernaly February 27, 2026 21:38

fbernaly requested a review from Copilot February 27, 2026 21:54

Copilot started reviewing on behalf of fbernaly February 27, 2026 21:55 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

bensonarafat and others added 4 commits February 27, 2026 23:08

Update packages/google_mlkit_commons/android/src/main/kotlin/com/goog…

eca2ea2

…le_mlkit_commons/InputImageConverter.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update packages/google_mlkit_commons/android/src/main/kotlin/com/goog…

2186da8

…le_mlkit_commons/InputImageConverter.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update packages/google_mlkit_commons/android/src/main/kotlin/com/goog…

2d9aee2

…le_mlkit_commons/InputImageConverter.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

refactor: Optimize image plane concatenation and update YUV_420_888 c…

ccc150a

…onversion to use reported format

fbernaly requested a review from Copilot February 27, 2026 22:25

Copilot started reviewing on behalf of fbernaly February 27, 2026 22:26 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

Update packages/google_mlkit_commons/android/src/main/kotlin/com/goog…

940ae04

…le_mlkit_commons/InputImageConverter.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

bensonarafat and others added 2 commits February 27, 2026 23:38

refactor: Replace ByteBuffer with IntBuffer in InputImageConverter

7c49386

Update packages/example/lib/vision_detector_views/camera_view.dart

7b1065f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fbernaly requested a review from Copilot February 27, 2026 22:47

Copilot started reviewing on behalf of fbernaly February 27, 2026 22:48 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

bensonarafat and others added 3 commits February 27, 2026 23:55

Update packages/google_mlkit_commons/android/src/main/kotlin/com/goog…

e743260

…le_mlkit_commons/InputImageConverter.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update packages/example/lib/vision_detector_views/camera_view.dart

79eddc4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: Improve error message for unsupported image formats in InputImag…

acaa0f6

…eConverter

fbernaly requested a review from Copilot February 27, 2026 23:08

Copilot AI reviewed Feb 27, 2026

View reviewed changes

packages/example/lib/vision_detector_views/camera_view.dart Outdated Show resolved Hide resolved

packages/example/lib/vision_detector_views/camera_view.dart Outdated Show resolved Hide resolved

packages/example/lib/vision_detector_views/camera_view.dart Outdated Show resolved Hide resolved

bensonarafat and others added 2 commits February 28, 2026 00:15

Update packages/example/lib/vision_detector_views/camera_view.dart

c8f789f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feat: Add support for converting YUV420 image formats to NV21 in Came…

025f7b8

…raView

fbernaly requested a review from Copilot March 1, 2026 00:52

Copilot started reviewing on behalf of fbernaly March 1, 2026 00:53 View session

Copilot AI reviewed Mar 1, 2026

View reviewed changes

packages/example/lib/vision_detector_views/camera_view.dart Outdated Show resolved Hide resolved

packages/example/lib/vision_detector_views/camera_view.dart Outdated Show resolved Hide resolved

packages/example/lib/vision_detector_views/camera_view.dart Outdated Show resolved Hide resolved

bensonarafat added 2 commits March 2, 2026 19:00

refactor: Update CameraView to use const for supported formats and si…

3f09e14

…mplify buffer return

fix: Add validation for U and V plane pixel strides in CameraView

ba129e7

fbernaly requested a review from Copilot March 2, 2026 18:16

Copilot started reviewing on behalf of fbernaly March 2, 2026 18:17 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

packages/example/lib/vision_detector_views/camera_view.dart Show resolved Hide resolved

packages/example/lib/vision_detector_views/camera_view.dart Outdated Show resolved Hide resolved

bensonarafat and others added 2 commits March 2, 2026 19:26

Update packages/example/lib/vision_detector_views/camera_view.dart

296f1a8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feat: Optimize YUV420 to NV21 conversion with reusable buffers

c2c6a33

fbernaly requested changes Mar 2, 2026

View reviewed changes

bensonarafat added 2 commits March 2, 2026 20:06

fix: Add newline for improved readability in BarcodeScanner, FaceMesh…

0142ff5

…Detector, and PoseDetector

fix: Add newlines for improved readability in BarcodeScanner, FaceMes…

4d0797e

…hDetector, and PoseDetector

fbernaly approved these changes Mar 2, 2026

View reviewed changes

fbernaly merged commit 0f39217 into flutter-ml:test Mar 2, 2026
1 check passed

Conversation

bensonarafat commented Feb 27, 2026

Uh oh!

bensonarafat commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fbernaly commented Feb 27, 2026

Uh oh!

bensonarafat commented Feb 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fbernaly commented Feb 27, 2026

Uh oh!

bensonarafat commented Feb 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fbernaly commented Feb 27, 2026

Uh oh!

bensonarafat commented Feb 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bensonarafat commented Feb 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fbernaly commented Mar 2, 2026

Uh oh!

bensonarafat commented Mar 2, 2026

Uh oh!

bensonarafat commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

bensonarafat commented Feb 27, 2026 •

edited

Loading