Open
Conversation
Since - for some reason - OS X needs the red color component to be shifted by 24 to the left, and `int` is 32 bits wide on OS X, using any color of which the red component is greater than 127 results in shifting a `1` to the sign bit of a signed `int`, which results in undefined behavior. This commit fixes that by declaring `draw_clr` as an `unsigned` integer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since - for some reason - OS X needs the blue color component to be shifted by 24 to the left, and
intis 32 bits wide on OS X, using any color of which the blue component is greater than 127 results in shifting a1to the sign bit of anint, which invokes undefined behavior. This commit fixes that by declaringdraw_clras anunsignedinteger.