Modernizations #81
Merged
Modernizations #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MA0002 - IEqualityComparer<string> or IComparer<string> is missing
SA1503 - Braces should not be omitted
We already do the same for S3928
IDE0040 - Accessibility modifier unnecessary
MA0048 - File name must match type name
SA1128, SA1502
CA1716: Identifiers should not match keywords
dennisdoomen
approved these changes
Nov 16, 2025
S3928 was from once when I locally had SonarQube installed
Pull Request Test Coverage Report for Build 19428600488Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noted that we didn't use several modern C# syntax features, so here goes