Added the option to ignore the order in arrays and collections #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 18630461237Details
💛 - Coveralls |
dennisdoomen
requested changes
Sep 28, 2025
Member
dennisdoomen
left a comment
dennisdoomen
left a comment
There was a problem hiding this comment.
⛏️ Would be nice to add small paragraph to the readme to mention this new option
Comment on lines
12
to
14
| JObject obj => new JObject(obj.Properties().OrderBy(p => p.Name).Select(p => new JProperty(p.Name, Normalize(p.Value)))), | ||
| JArray array => new JArray(array.Select(Normalize).OrderBy(x => x.ToString(Newtonsoft.Json.Formatting.None))), | ||
| _ => token |
Member
There was a problem hiding this comment.
⛏️ (nitpick) I would prefer to have this spelled out instead of a switch statement for readability
Tests/FluentAssertions.Json.Specs/WithoutStrictOrderingSpecs.cs
Outdated
Show resolved
Hide resolved
Tests/FluentAssertions.Json.Specs/WithoutStrictOrderingSpecs.cs
Outdated
Show resolved
Hide resolved
Tests/FluentAssertions.Json.Specs/WithoutStrictOrderingSpecs.cs
Outdated
Show resolved
Hide resolved
dennisdoomen
changed the title
dennisdoomen
approved these changes
Sep 29, 2025
jnyrup
reviewed
Oct 3, 2025
Tests/FluentAssertions.Json.Specs/WithoutStrictOrderingSpecs.cs
Outdated
Show resolved
Hide resolved
jnyrup
reviewed
Oct 9, 2025
jnyrup
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This merge request introduces the
WithoutStrictOrderingmethod to theIJsonAssertionOptions<T>interface. This method allows users to configure JSON assertions to ignore the order of elements in arrays or collections during comparison, enabling equivalency checks regardless of element sequence.Changes
WithoutStrictOrdering()toIJsonAssertionOptions<T>.Motivation
The addition of
WithoutStrictOrderingprovides greater flexibility in JSON assertions by allowing tests to pass even when the order of array or collection elements differs between the subject and expectation.Impact