Updated reload_connections set false by default in in_opensearch.rb#140
Open
OlehPalanskyi wants to merge 10 commits intofluent:mainfrom
Open
Updated reload_connections set false by default in in_opensearch.rb#140OlehPalanskyi wants to merge 10 commits intofluent:mainfrom
OlehPalanskyi wants to merge 10 commits intofluent:mainfrom
Conversation
Signed-off-by: Oleh <o.palanskyi@socprime.com>
Signed-off-by: OlehPalanskyi <Trahterber@gmail.com> Signed-off-by: Oleh <o.palanskyi@socprime.com>
Signed-off-by: OlehPalanskyi <Trahterber@gmail.com> Signed-off-by: Oleh <o.palanskyi@socprime.com>
cosmo0920
requested changes
Aug 29, 2024
| user: host[:user], | ||
| password: host[:password], | ||
| reload_connections: @reload_connections, | ||
| # reload_connections: @reload_connections, |
Contributor
There was a problem hiding this comment.
Hey, could you describe why this line is commented out?
Would you mind if you revive this line?
lib/fluent/plugin/in_opensearch.rb
Outdated
| @retry.step | ||
| if error.message.include?('EOFError (EOFError)') | ||
| log.error("Restart plugin because hit error #{error.message}") | ||
| exit(1) |
Contributor
There was a problem hiding this comment.
exit(1) caused entire termination. This is brutal manner for handling this exception. :(
added Faraday::TimeoutError in retry function
Refactor retry logic
Contributor
|
@OlehPalanskyi Thanks for this improvement!
It appears that some diffs are not related to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi i getting this error in input when set parameter reload_connections true.
But I found if we set parameter reload_connections false we stop getting this error.
This way I set this parameter reload_connections false by default in code.