Open
Conversation
joshuabaird
force-pushed
the
chore/helm-v4-refactor
branch
from
9e97d2b to
d3e721f
Compare
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
joshuabaird
force-pushed
the
chore/helm-v4-refactor
branch
from
c17fc63 to
6817b70
Compare
Signed-off-by: Josh Baird <jbaird@galileo.io>
stevehipwell
suggested changes
Feb 27, 2026
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
@joshuabaird this looks like a better pattern, I've added a couple of nits that may be useful.
RE the bigger picture, I think the following are worth considering.
- Don't keep the README in this repo
- Keep the README template in the helm-charts repos and generate the README as part of the PR to copy the chart there
- This will make it clearer that the chart in this repo shouldn't be used
- Don't Update Chart.yaml
versionin this repo- Keep
versionstatic (e.g.0.0.1-dev.0) - Update
appVersionas appropriate - Set the version in the PR to copy the chart to the helm-charts repo
- This will make it clearer that the chart in this repo shouldn't be used
- Keep
charts/fluent-operator-crds/templates/fluent-bit/fluentbit.fluent.io_clusterfilters.yaml
Outdated
Show resolved
Hide resolved
charts/fluent-operator-crds/templates/fluent-bit/fluentbit.fluent.io_clusterfilters.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
stevehipwell
suggested changes
Mar 2, 2026
charts/fluent-operator/crds/fluentbit.fluent.io_clusterfilters.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
joshuabaird
requested review from
marcofranssen
and removed request for
stevehipwell
Rename values key from 'fluent-bit' to 'fluentbit' in fluent-operator-crds chart. Hyphenated keys cannot be accessed via dot notation in Go templates (.Values.fluent-bit.enabled is parsed as arithmetic subtraction), causing a hard parse error on helm template/lint. Signed-off-by: Josh Baird <jbaird@galileo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements several re-factors for the initial Helm chart v4 release of
fluent-operator:crds/directory of thefluent-operatorchart to follow Helmv3 standards and best practicesfluent-operator-crdschart that enables optional advanced/out-of-band management of the fluentd and fluent-bit CRDsfluent-operatorchartfluent-bit-crdsandfluentd-crdscharts (no longer necessary since we introduced thefluent-operator-crdschart)values.yamlto be compatible withhelm-docsso we can autogenerate docs for the chart_docs.mdso it gets picked up by templating already in place over in fluent/helm-charts