lib: Do not use private makefile targets in CMakelists.txt#9450
lib: Do not use private makefile targets in CMakelists.txt#9450nikomauno wants to merge 1 commit intofluent:masterfrom
Conversation
nikomauno
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
|
It looks like these are all in upstream dependencies so really should be updated there and then the new versions sync'd to Fluent Bit. I don't think this will be accepted. |
|
Additionally you've made a change to Windows builds so really need to verify it functions for that target too. |
patrick-stephens
added
ok-package-test
By extending the scope of changes introduced in commit fc32552 ("build: CMakeLists.txt Do not use private makefile targets (fluent#5819)") we mitigate the following error produced by BitBake in Yocto ERROR: fluentbit-3.1.9-r0 do_package_qa: QA Issue: File /usr/bin/fluent-bit in package fluentbit contains reference to TMPDIR [buildpaths] ERROR: fluentbit-3.1.9-r0 do_package_qa: Fatal QA errors were found, failing task. stemming from $ strings packages-split/fluentbit/usr/bin/fluent-bit ... $(subst /yocto/upstream/build/tmp/work/cortexa57-poky-linux/fluentbit/3.1.9/git/,,$(abspath $<)) ... Signed-off-by: Niko Mauno <niko.mauno@vaisala.com>
nikomauno
force-pushed
the
master-fix-cmakelists
branch
from
940a4e2 to
3bf76a1
Compare
Indeed, that was not intentional -- updated commit to avoid this from happening. |
Thank You for pointing this out, as a first time submitter I was wholly unaware of the fact. |
|
As an update, as advised I have now opened respective upstream pull requests: |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
2 participants
By extending the scope of changes introduced in commit fc32552
("build: CMakeLists.txt Do not use private makefile targets (#5819)") we mitigate the following error produced by BitBake in Yocto
stemming from
$ strings packages-split/fluentbit/usr/bin/fluent-bit ... $(subst /yocto/upstream/build/tmp/work/cortexa57-poky-linux/fluentbit/3.1.9/git/,,$(abspath $<)) ...Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.