Skip to content

Conversation

@TintinSDev
Copy link

/claim #7

@opirebot
Copy link

opirebot bot commented Jul 20, 2024

👀 We've notified the reward creators here.
Make sure you have your payment account ready to receive the payment for your hard work 💪

@TintinSDev
Copy link
Author

/claim #7

@opirebot
Copy link

opirebot bot commented Jul 20, 2024

🤝 You already claimed this issue, you don't have to do it again!

@flowese
Copy link
Owner

flowese commented Jul 20, 2024

Hi @TintinSDev

Thank you for your contribution. Before merging the pull request, could you please update the README.md file with a description of the changes made? Also, I noticed that a venv directory was created for dependencies. Could you instead list the dependencies in a requirements.txt file? This will make it easier for others to install the required packages.

Thanks in advance!

Best regards,

@bitnom
Copy link

bitnom commented Jul 21, 2024

Why was an entire python venv committed? This is not the way.

I am also questioning the need for nginx but haven't inspected that part yet. Will take a look.

@TintinSDev
Copy link
Author

Why was an entire python venv committed? This is not the way.

I am also questioning the need for nginx but haven't inspected that part yet. Will take a look.

I'll be removing the venv dir

@TintinSDev
Copy link
Author

Hi @TintinSDev

Thank you for your contribution. Before merging the pull request, could you please update the README.md file with a description of the changes made? Also, I noticed that a venv directory was created for dependencies. Could you instead list the dependencies in a requirements.txt file? This will make it easier for others to install the required packages.

Thanks in advance!

Best regards,

Hello @flowese
I'll be doing that and pushing the changes. Thank you for the comment and guidance.

@flowese
Copy link
Owner

flowese commented Jul 24, 2024

Hi @TintinSDev

I have reviewed the changes and noticed that you have updated the README, which is great, thank you for that!

However, I have a few questions:

Could you explain a bit more about the need to implement a reverse proxy with Nginx? I would like to better understand the purpose and benefits this brings to the project. As @bitnom mentioned, the implementation of Nginx doesn't seem justified and complicates the use of this wrapper, as users would need to provision and configure Nginx.

TwoCaptcha is a paid service, and since this wrapper is open source and free, is there any option for users to solve captchas manually without relying on a third-party service? This could be useful for those who prefer not to incur additional costs. Perhaps we could offer an option for users to solve captchas manually or integrate another method that doesn't involve additional costs for users.

Thanks in advance for the clarification!

Best regards,

@markus583
Copy link

Hi @TintinSDev, any updates on this? Would be highly appreciated!

@markus583 markus583 mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants