proposing removal of unused utilities code #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelkomarov
commented
Nov 19, 2025
| return x_hat/weight_sum, dxdt_hat/weight_sum | ||
|
|
||
|
|
||
| def peakdet(x, delta, t=None): |
Collaborator
Author
There was a problem hiding this comment.
Moved this guy to the bottom, because it's only used by the Triangles simulations.
… seeks to make first term sparse, because that's advantageous to the loss function, which artificially pushes huberM low. RMSEs tend to be better when huberM isn't allowed to shrink to 0. Also realized I was multiplying M by sigma in TVR, but the inputs are already scaled, so M should just be M, doesn't need to be scaled there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I so far just left it there, even wrote tests for some of it, but it's not used and doesn't seem like it's going to be used, so I think it's worth getting rid of to simplify things.