Skip to content

trying a few things to see whether CI goes through #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pavelkomarov wants to merge 2 commits into from
Closed

trying a few things to see whether CI goes through #153

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eed00cd
trying changing the random seed to see whether CI goes through
pavelkomarov Aug 24, 2025
be89ff9
trying again
pavelkomarov Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions pynumdiff/tests/test_optimize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,10 @@ def test_polydiff():
assert (params1['degree'], params1['window_size'], params1['kernel']) == (6, 50, 'friedrichs')
assert (params2['degree'], params2['window_size'], params2['kernel']) == (3, 10, 'gaussian')

# This test runs in a reasonable amount of time locally but for some reason takes forever in CI
# def test_rtsdiff_with_irregular_step():
# t = np.arange(len(x))*dt; np.random.seed(7) # seed so the test can't randomly fail
# t_irreg = t + np.random.uniform(-dt/10, dt/10, *t.shape) # add jostle
# params1, val1 = optimize(rtsdiff, x, t, dxdt_truth=dxdt_truth)
# params2, val2 = optimize(rtsdiff, x, t_irreg, dxdt_truth=dxdt_truth)
# assert val2 < 1.15*val1 # optimization works and comes out similar, since jostle is small
# assert params1['qr_ratio']*0.85 < params2['qr_ratio'] < params1['qr_ratio']*1.15
def test_rtsdiff_with_irregular_step():
t = np.arange(len(x))*dt; np.random.seed(7) # seed so the test can't randomly fail
t_irreg = t + np.random.uniform(-dt/10, dt/10, *t.shape) # add jostle
params1, val1 = optimize(rtsdiff, x, t, dxdt_truth=dxdt_truth, search_space_updates={'forwardbackward':False})
params2, val2 = optimize(rtsdiff, x, t_irreg, dxdt_truth=dxdt_truth, search_space_updates={'forwardbackward':False})
assert val2 < 1.2*val1 # optimization works and comes out similar, since jostle is small
assert params1['qr_ratio']*0.8 < params2['qr_ratio'] < params1['qr_ratio']*1.2
Loading