Fix native image startup on x86-64-v2 CPUs#301
Closed
utafrali wants to merge 1 commit intofloci-io:mainfrom
Closed
Fix native image startup on x86-64-v2 CPUs#301utafrali wants to merge 1 commit intofloci-io:mainfrom
utafrali wants to merge 1 commit intofloci-io:mainfrom
Conversation
Collaborator
Contributor
Author
|
makes sense, properties being global would affect all platforms. closing this in favor of your approach in #303 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #287
Native image was being compiled for generic x86-64, which doesn't work on x86-64-v2 CPUs. Added the -march flag so GraalVM targets that instruction set.
Type of change
fix:)feat:)feat!:orfix!:)AWS Compatibility
The native image was failing to start on x86-64-v2 CPU instances. The fix tells GraalVM to compile for that specific CPU level, so the binary runs on those systems.
Checklist
./mvnw testpasses locally