test(dynamodb): add coverage for numeric ExpressionAttributeNames (#0, #1)#166
Closed
rpalcolea wants to merge 2 commits intofloci-io:mainfrom
Closed
test(dynamodb): add coverage for numeric ExpressionAttributeNames (#0, #1)#166rpalcolea wants to merge 2 commits intofloci-io:mainfrom
rpalcolea wants to merge 2 commits intofloci-io:mainfrom
Conversation
…floci-io#1) Adds unit and integration tests verifying that numeric placeholder aliases in ExpressionAttributeNames are resolved correctly across: - Query KeyConditionExpression: #0 = :0 AND begins_with(floci-io#1, :prefix) - TransactWriteItems ConditionExpression: attribute_not_exists(#0) Covers the scenario reported in floci-io#127 where PynamoDB-style numeric aliases were not being resolved, causing zero query results and spurious TransactionCanceledExceptions. Fixes floci-io#127
There was a problem hiding this comment.
Pull request overview
Adds DynamoDB test coverage to ensure numeric placeholder aliases (e.g., #0, #1) in ExpressionAttributeNames are correctly resolved in expressions, matching common PynamoDB-generated request patterns and guarding against the regression reported in #127.
Changes:
- Add a unit test covering numeric
ExpressionAttributeNamesresolution inQueryKeyConditionExpression. - Add an integration test covering numeric aliases in
Querywithbegins_with. - Add an integration test covering numeric aliases in
TransactWriteItemsConditionExpression(attribute_not_exists(#0)).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/test/java/io/github/hectorvent/floci/services/dynamodb/DynamoDbServiceTest.java | Adds unit coverage for numeric ExpressionAttributeNames in a Query key condition expression. |
| src/test/java/io/github/hectorvent/floci/services/dynamodb/DynamoDbIntegrationTest.java | Adds integration coverage for numeric aliases in Query and TransactWriteItems requests over the JSON 1.0 wire protocol. |
hectorvent
requested changes
Apr 1, 2026
Collaborator
hectorvent
left a comment
hectorvent
left a comment
There was a problem hiding this comment.
Thanks @rpalcolea,
Please solve copilot review. Test Order duplicate.
Collaborator
|
@rpalcolea is this just to validate the issue is already solved? Could we close #127? |
Collaborator
|
@rpalcolea Are you going to create the service(function) related to those tests? Because the function that corrects the fix has not yet been created; it has not been implemented yet. |
7 tasks
Updated test method order for DynamoDbIntegrationTest. Signed-off-by: Hector Ventura <hectorvent@gmail.com>
Collaborator
|
Closing as it is not required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit and integration tests verifying that numeric placeholder aliases in ExpressionAttributeNames are resolved correctly across:
Covers the scenario reported in #127 where PynamoDB-style numeric aliases were not being resolved, causing zero query results and spurious TransactionCanceledExceptions.
Associated to #127
Type of change
fix:)feat:)feat!:orfix!:)Checklist
./mvnw testpasses locally