fix(fetcher): decode address names#1669
Open
2005czq wants to merge 1 commit into
Open
Conversation
floatpanebot
added
target/v1
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the IMAP fetcher’s address formatting so RFC 2047 encoded-word display names are decoded before being surfaced to the rest of the application, avoiding raw =?UTF-8?...?= sequences in sender strings.
Changes:
- Decode
imap.Address.Namevia existingdecodeHeader()when building"Name <email>"informatAddress().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
134
to
138
| func formatAddress(addr imap.Address) string { | ||
| email := addr.Addr() | ||
| if addr.Name != "" { | ||
| return addr.Name + " <" + email + ">" | ||
| return decodeHeader(addr.Name) + " <" + email + ">" | ||
| } |
Comment on lines
136
to
138
| if addr.Name != "" { | ||
| return addr.Name + " <" + email + ">" | ||
| return decodeHeader(addr.Name) + " <" + email + ">" | ||
| } |
Author
There was a problem hiding this comment.
I think it would be better to address this centrally in decodeHeader() in a separate PR, since decoded subjects already use the same helper.
I'll keep this PR focused on applying the existing decoder to address display names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Use the existing
decodeHeader()helper forimap.Address.NameinformatAddress().Why?
RFC 2047 encoded-word display names can currently be shown raw in address headers, for example:
instead of: