fix(ci): always tag distribution even when content unchanged#18
Merged
Conversation
When the source version moves from e.g. v3.0.0-rc.1 to v3.0.0 with no file changes, the previous workflow short-circuited on the no-diff branch and skipped the tag. Distribution repo was missing the v3.0.0 tag after Task 21. Splits the step into four: conditional commit, unconditional tag, conditional push-commit, unconditional push-tag. The distribution repo now always gets a matching tag for every source release tag. Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Review Summary by QodoAlways tag distribution on release, even with unchanged content
WalkthroughsDescription• Splits publish workflow into four independent steps for reliability • Tag creation now always executes, regardless of content changes • Commit and push operations remain conditional on actual changes • Fixes issue where rc→final releases with identical content skipped tagging Diagramflowchart LR
A["Check for changes"] --> B["Commit if changed"]
B --> C["Tag always"]
C --> D["Push commit if changed"]
D --> E["Push tag always"]
File Changes1. .github/workflows/publish-plugin.yml
|
Code Review by Qodo
1. Misleading summary env name
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered during Task 21: the publish workflow's no-diff gate was preventing the tag from being created when rc → final releases had byte-identical content. Splits the step into four so tag creation is independent from commit creation.
Follow-up to #16.
🤖 Generated with Claude Code
Note
Low Risk
Low risk workflow refactor that only changes publish/tagging behavior in GitHub Actions. Main risk is accidental extra tag pushes or mismatched commit/tag if the distribution repo state is unexpected.
Overview
Updates the
publish-pluginGitHub Actions workflow to decouple tagging from committing when publishing to the distribution repo.The workflow now commits only when staged content differs (exposing
committed=true/false), but it always creates and pushes the distribution tag even if there were no content changes (e.g., RC → final with identical bytes). The final summary output is updated to report whether a commit was made.Reviewed by Cursor Bugbot for commit e9c6ffe. Bugbot is set up for automated code reviews on this repo. Configure here.